Repository navigation
Repo - API! - Consolidate the v2 deck sections, driver and HDF5 writers - #602
Draft
matt-pharr wants to merge 52 commits into
Draft
matt-pharr wants to merge 52 commits into
matt-pharr wants to merge 52 commits into
Conversation
…broken Run main and the scripting API on the same Solovev deck for Galerkin, Riccati Δ′, hdf5 file forcing, the analytic two-pass grid and gal_match_flag matching. Mark the known drifts @test_broken: file-forcing normalization, the analytic two-pass grid, the cut solution implied under gal_match_flag, and the fixed kinetic source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ount Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remove the runtimes keyword from run_force_free_states, perturbed_equilibrium, compute_perturbed_equilibrium, run_perturbed_equilibrium and run_slayer_stage. main times every stage from outside: PerturbedEquilibrium, KineticForces and ErrorFields each get one banner and one timer through _timed_stage, so they are no longer timed twice. Info/Runtimes drops the galerkin and forcing_terms sub-stage entries, which only a stage could measure from inside. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The :ray model returns no inner profiles by default since #536, so the cut-solution drift only shows with real-ψ profiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…section and ODE tolerances on Ballooning
…Stability] section
… the old key fail as an unknown keyword No backward-compatibility code: remove the EulerLagrangeProblem error for local_stability_flag, its deprecated-key pre-commit entry, the two tests asserting it errors, and the docs sentence naming it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gal_cut_solution is no longer a ForceFreeStatesControl field or a deprecated deck key. Galerkin(; cut_solution=true) passes it to galerkin_solve as a solve option, so only a script can keep the cut solution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nto refactor/deck-match-in-main
…si, and smoke-test the gpec.h5 plots
…efactor/v2-consolidation
…o refactor/v2-consolidation
… into refactor/v2-consolidation
…nto refactor/v2-consolidation
…actor/v2-consolidation
… refactor/v2-consolidation
…to refactor/v2-consolidation
…efactor/v2-consolidation
…librium' into refactor/v2-consolidation
… the calculated-kinetic deck
…refactor/v2-consolidation
Implement consolidation spec commits 1 and 2 together: introduce the shared save protocol, give stage results their own writers, and move file writes from computation into the driver. Keep schema metadata in Utilities, preserve the HDF5Schema title Area, and record FFS input provenance for explicit script saves. Validate focused FFS output, frozen equilibrium, multi-ion, tearing, torque-response, and error-field tests, plus documentation. The SDCC comparison against wall-port commit 14a3745 follows this commit.
…roblem Rename the public problem type, constructor, solve dispatch, exports, tests, and API references without retaining an alias. Keep internal Euler-Lagrange file and function names. Describe the kinetic force-balance operator as non-self-adjoint rather than an energy extremization. Validate the renamed API and explicit FFS output tests (8 assertions), plus documentation.
…ects Implement consolidation spec commit 4. Put ODE numerics on Forward and Riccati, with extended-precision BVP solving on Riccati only. Keep physical domain and Frobenius settings on the problem, rejecting unsupported Galerkin combinations. Use automatic Galerkin factorization and algorithm fields without gal_ prefixes. Retain the temporary deck translator and twelve matching controls until the deck switch; route removed keys through the existing stop list and hook. Defer manual numerical tests to CI as requested. Compare this committed checkpoint against 4f9e4d6 with the SDCC regression harness.
…erics Implement consolidation spec commit 5. Move theta_k and alpha_boundary_scan onto LocalStabilityProblem and make verbose a solve keyword defaulting to false. Keep the current deck layout through the adapter, forwarding only explicitly supplied problem keys so constructor defaults remain authoritative. Update API documentation and CI tests; defer manual tests as requested.
…c' into refactor/v2-consolidation
…ctor/v2-consolidation
…through TearingProblem
…d resistivity closure on the kinetic data
… psilim from the layer overlap inside solve
…on and stop early by omitting sections
…dir_path from the force-balance problem and result
…etic keyword and make kinetic_factor a plain scale
… per-integrator, matching and tearing sections
Brings #581 as merged, with its two final fixes. The deck stops for the kinetic file named under [KineticForces] (kinetic_file) or [SLAYER] (profile_file, profile_group) move to src/Deck.jl's moved-key list with develop's remedy, and the hook rejects the [SLAYER] keys. Rerun takes develop's _replay_kinetic_profiles. Also fixes tests stale since the tearing rework: the dispersion tests use Tearing.Dispersion and GrowthRateResult's omega/gamma, and the multi-ion species test reads ion_species from [Equilibrium].
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Release note
Consolidates GPEC's scripting API, deck format and output for v2.0.0: one deck section per object a
script constructs, one
mainthat runs the same public calls a script does, and onesave_to_hdf5with a method per result type.Regression report
Notes for reviewers
Not ready for review. Currently merged in beyond develop: #572-free prototype of the open roadmap
PRs (#551, #546/#552/#554, #564, #567, #568/#573, #555); upcoming: #571, #493, the PR 17 port,
the optional-wall port, and develop merges as #513, #501 and #415 land.
🤖 Generated with Claude Code