Add 4 variants to elegoo pla_cf - #450
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds four new color variants under data/elegoo/PLA/pla_cf to expand the Elegoo PLA-CF dataset with additional purchasable options.
Changes:
- Added
variant.jsonentries for Carbon Fiber Blue/Purple/Red/Green. - Added corresponding
sizes.jsonentries with 1kg / 1.75mm purchase links. - Introduced per-size spool metadata (empty spool weight, core diameter) for these variants.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| data/elegoo/PLA/pla_cf/carbon_fiber_red/variant.json | New red variant metadata (id/name/color/discontinued). |
| data/elegoo/PLA/pla_cf/carbon_fiber_red/sizes.json | New size entry and purchase link for red variant. |
| data/elegoo/PLA/pla_cf/carbon_fiber_purple/variant.json | New purple variant metadata (id/name/color/discontinued). |
| data/elegoo/PLA/pla_cf/carbon_fiber_purple/sizes.json | New size entry and purchase link for purple variant. |
| data/elegoo/PLA/pla_cf/carbon_fiber_green/variant.json | New green variant metadata (id/name/color/discontinued). |
| data/elegoo/PLA/pla_cf/carbon_fiber_green/sizes.json | New size entry and purchase link for green variant. |
| data/elegoo/PLA/pla_cf/carbon_fiber_blue/variant.json | New blue variant metadata (id/name/color/discontinued). |
| data/elegoo/PLA/pla_cf/carbon_fiber_blue/sizes.json | New size entry and purchase link for blue variant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
LGTM! |
ofd-anon-pr-bot
Bot
deleted the
ofd-anon-44beabe4-d8c2-42fe-b1f3-c2d45fc7498c
branch
August 16, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted via Open Filament Database web editor.
Changes
Submitted via SimplyPrint