[Fix] Forward packed dataset mode to GPT-OSS preprocessors - #1276
Open
primorLee wants to merge 1 commit into
Open
[Fix] Forward packed dataset mode to GPT-OSS preprocessors#1276primorLee wants to merge 1 commit into
primorLee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_packed_dsfromLazySupervisedDatasetto the selected preprocessorProblem
For Qwen3-style SFT,
get_preprocess_function()selectspreprocess_internvl2_5. That preprocessor only disables per-sample max-length padding whengroup_by_lengthoruse_packed_dsis true. Packed training intentionally does not rely ongroup_by_length, but the dataset did not forwardself.use_packed_ds, so each item could be padded totokenizer.model_max_lengthbefore reachingPackedDataset. This defeats variable-length packing and changes the effective token composition.Validation
python -m pytest tests/test_gpt_oss_packed_preprocessing.py -q(1 test, 4 subtests passed)python -m compileall -q ...on Windows Python 3.12mainsource because all four call sites omit the flagmainCloses #1166