Skip to content

Allow generated classes to unload from the compiler cache - #135

Open
kimec wants to merge 1 commit into
OpenHFT:developfrom
kimec:class-unloading
Open

Allow generated classes to unload from the compiler cache#135
kimec wants to merge 1 commit into
OpenHFT:developfrom
kimec:class-unloading

Conversation

@kimec

@kimec kimec commented Jun 10, 2024

Copy link
Copy Markdown

Store weak references to generated classes in the per-class-loader compiler cache. A strong cached Class can otherwise keep its defining loader alive even when the loader is a weak map key. Recompile entries whose class reference has been collected.

Add a regression that compiles and invokes a class in a disposable loader, releases it, and waits for collection through a reference queue.

The collection check depends on GC progress and needs supported-JVM execution. The discussion records outstanding contributor/CI arrangements for the fork; this metadata update does not resolve those arrangements or establish deterministic class unloading.

Validation: the diff and recorded review/check history were inspected at 908c8c9bd14c. No build, test or benchmark was rerun for this metadata edit. No CI result was returned for this head.


Existing author and review notes

Fix class unloading.

@kimec kimec mentioned this pull request Jun 10, 2024
@yevgenp
yevgenp changed the base branch from ea to develop June 18, 2024 08:52
@yevgenp
yevgenp requested a review from peter-lawrey June 18, 2024 09:01
@yevgenp

yevgenp commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

Hi @kimec. Thanks for the contribution.
Could you move your changes to a branch in this repository and adjust the PR?
So that our CI system picks up and runs your test.

@yevgenp

yevgenp commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

@kimec And you will have to sign https://chronicle.software/contributor-agreement/ also.

@kimec

kimec commented Jun 21, 2024

Copy link
Copy Markdown
Author

Hello @yevgenp . I've tried to push to this repo, but I do not have the rights. I will sign the contributor agreement shortly

@tgd
tgd requested review from tgd and removed request for peter-lawrey September 27, 2024 18:01
@tgd
tgd removed their request for review May 5, 2026 07:31
@peter-lawrey peter-lawrey changed the title Fix class unloading Allow generated classes to unload from the compiler cache Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants