[#60] Add a deterministic explicit JPMS descriptor - #122
Open
peter-lawrey wants to merge 8 commits into
Open
Conversation
Member
Author
This was referenced Aug 21, 2026
|
It is totally fine as a start |
Base automatically changed from
feat/Zero-Allocation-Hashing-60-review-pr-107-for-compatibility-ci
to
develop
September 9, 2026 15:02
peter-lawrey
marked this pull request as ready for review
September 11, 2026 18:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Produce an explicit
net.openhft.hashingmodule descriptor deterministically, including when Maven builds the Java-8-targeted library on Java 8. Preserve the multi-release layout, automatic module name, packaged-JAR assertions and class-path/module-path consumer projects from #107/#119.The branch now includes develop at
f06d8ecc3e8887a9d53546c1e69cdaa9b76dadb2. Resolve the overlapping #119 additions by retaining both the automatic-module-name check and the stronger Java 9 descriptor check, together with ModiTect and Invoker configuration. Original #107 history, including Benjamin Marwell's commitcdbdc5060cddb1373a86a1575445b68f1b1d08c0, remains unchanged in the ancestry.Select the modular consumer on Java 11+ to match its
--release 11compilation target. This controls which JVMs execute that fixture; it does not raise the library's Java 8 target or the module descriptor's Java 9 class version. Apply the Actions setup repair already used by #123 so both layers use current checkout/cache/Java actions; the scanner runs on Java 21 and Sonar analysis remains enabled.Fresh Linux amd64 validation:
Ready for review of the reconciled packaging increment. #123 adds the stronger hash oracle and broader runtime matrix. Supported-platform CI and SonarCloud configuration remain merge gates. Preserve the original contribution's history when delivering this PR.
Refs #60, #107, #119.