Fix FastAPI path parameter binding in delete_sandbox endpoint - #11
Open
mathiscode wants to merge 1 commit into
Open
Fix FastAPI path parameter binding in delete_sandbox endpoint#11mathiscode wants to merge 1 commit into
mathiscode wants to merge 1 commit into
Conversation
Changed route decorator from `/{id}` to `/{sandbox_id}` to match the function parameter name.
This fixes the parameter binding mismatch where FastAPI was unable to bind the path segment
to the sandbox_id parameter, causing it to be treated as a query parameter instead.
The fix makes the delete_sandbox endpoint consistent with other sandbox routes like pause and resume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed route decorator from
/{id}to/{sandbox_id}to match the function parameter name. This fixes the parameter binding mismatch where FastAPI was unable to bind the path segment to the sandbox_id parameter, causing it to be treated as a query parameter instead.The fix makes the delete_sandbox endpoint consistent with other sandbox routes like pause and resume.