Repository navigation
chore(typescript): agent-server to v1.49.0 - #5107
all-hands-bot wants to merge 1 commit into
Conversation
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was posted by an AI agent (OpenHands).
Scope
This change belongs here: clients/typescript/ owns the browser-compatible mirror of the Agent Server API, and .github/workflows/version-bump-prs.yml is the workflow that opens exactly this bump-typescript-agent-server-X.Y.Z PR after an SDK release. The PR only bumps the pinned image in package.json (1.47.0 -> 1.49.0) and regenerates src/generated/agent-server-schema.ts from the release's openapi.json, which matches the documented flow (SDK/Agent Server -> OpenAPI contract -> TypeScript client).
Technical review
The generated contract and the pin are consistent and clean:
clients/typescript/package.jsonconfig.agentServerImageis nowghcr.io/openhands/agent-server:1.49.0-python, and the generated file header reflectsSource: ghcr.io/openhands/agent-server:1.49.0-python.- The regeneration is self-consistent:
npm run build(tsc type check) passes,npm testpasses (20 files, 328 tests), and the only public API removals in the generated file (DesktopUrlResponse/GetDesktopUrlApiDesktopUrlGet*) have no remaining references anywhere inclients/typescript. - The new
/api/conversations/{runtime_conversation_id}/...route family (file,bash,git,vscode) and theConversationRuntime*types are pure additions to the contract. No hand-written client code imports removed or renamed generated symbols, so there is no dangling-reference breakage.
No line-level findings.
Blocking issue - required PR description validation is failing
The Validate PR description check fails on this head (eb64116) with 7 errors: it is missing the template AGENT: marker, ## Why, ## Summary, ## How to Test, and ## Issue Number sections, plus the human-authored HUMAN: note. Because this is a required check, mergeStateStatus is BLOCKED. The repository requires PRs to use the PR template, and per AGENTS.md the HUMAN: section may only be filled in by a human contributor - so a human needs to complete the description (which also supplies the reviewer-facing how-to-test record) before this can merge. This is the only material issue and it is not fixable from the automation side.
Verification context: everything else on this head is green - TypeScript client CI, TypeScript client integration tests, TypeScript client endpoint audit, Run tests, REST API breakage checks, and Version bump guard all pass.
🔄 CHANGES REQUESTED
|
Closing as obsolete: since #5476 the release PR pins the TypeScript client to its own Agent Server version, and |
|
I'm on it! VascoSch92 can track my progress at all-hands.dev |
|
Confirmed — closing is the right call, and I'm leaving this PR closed with no further changes. I verified the rationale:
This 1.49.0 bump is superseded, so nothing needs to be pushed here. This comment was created by an AI agent (OpenHands) on behalf of the user. |
|
I'm on it! VascoSch92 can track my progress at all-hands.dev |
|
I've handled the comment. Here's the summary: Outcome: no action needed — the PR is correctly closedThe comment was a closure notice, not a code-change request. The PR (#5107, pinning the TypeScript client to agent-server v1.49.0) is already closed and not merged ( I verified every claim in the closure rationale rather than taking it at face value:
Since the branch's No commits or pushes were made — the correct action here was to confirm the closure, not to modify code. |
|
No action needed — I verified the comment's rationale and confirmed the PR should remain closed with no further changes. Verification performed via the GitHub API:
This confirms the 1.49.0 bump is superseded by the release-PR pinning change, exactly as the comment states. The comment is an acknowledgment rather than a request, so I made no code edits, committed nothing, and pushed nothing. The branch |
Bump tracked Agent Server version
Updates from Agent Server v1.47.0 to v1.49.0 and regenerates its checked-in OpenAPI contract.
Agent Server API change summary
ArchiveDirectoryApiConversationsRuntimeConversationIdFileArchiveGetData,ArchiveDirectoryApiConversationsRuntimeConversationIdFileArchiveGetError,ArchiveDirectoryApiConversationsRuntimeConversationIdFileArchiveGetErrors,ArchiveDirectoryApiConversationsRuntimeConversationIdFileArchiveGetResponse,ArchiveDirectoryApiConversationsRuntimeConversationIdFileArchiveGetResponses,BatchGetBashEventsApiConversationsRuntimeConversationIdBashBashEventsGetData,BatchGetBashEventsApiConversationsRuntimeConversationIdBashBashEventsGetError,BatchGetBashEventsApiConversationsRuntimeConversationIdBashBashEventsGetErrors,BatchGetBashEventsApiConversationsRuntimeConversationIdBashBashEventsGetResponse,BatchGetBashEventsApiConversationsRuntimeConversationIdBashBashEventsGetResponses,BodyUploadFileQueryApiConversationsRuntimeConversationIdFileUploadPost,ClearAllBashEventsApiConversationsRuntimeConversationIdBashBashEventsDeleteData,ClearAllBashEventsApiConversationsRuntimeConversationIdBashBashEventsDeleteError,ClearAllBashEventsApiConversationsRuntimeConversationIdBashBashEventsDeleteErrors,ClearAllBashEventsApiConversationsRuntimeConversationIdBashBashEventsDeleteResponse,ClearAllBashEventsApiConversationsRuntimeConversationIdBashBashEventsDeleteResponses,ConversationRuntimeError,ConversationRuntimeInfo,ConversationRuntimeStatus,CreateDirectoryApiConversationsRuntimeConversationIdFileCreateDirectoryPostData,CreateDirectoryApiConversationsRuntimeConversationIdFileCreateDirectoryPostError,CreateDirectoryApiConversationsRuntimeConversationIdFileCreateDirectoryPostErrors,CreateDirectoryApiConversationsRuntimeConversationIdFileCreateDirectoryPostResponse,CreateDirectoryApiConversationsRuntimeConversationIdFileCreateDirectoryPostResponses,DownloadFileQueryApiConversationsRuntimeConversationIdFileDownloadGetData, and 76 moreDesktopUrlResponse,GetDesktopUrlApiDesktopUrlGetData,GetDesktopUrlApiDesktopUrlGetError,GetDesktopUrlApiDesktopUrlGetErrors,GetDesktopUrlApiDesktopUrlGetResponse,GetDesktopUrlApiDesktopUrlGetResponsesTriggered by https://github.com/OpenHands/software-agent-sdk/releases/tag/v1.49.0.
🐳 Agent Server images for this PR — GHCR package, pull/run commands, and all pushed tags (click to expand)
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdkpython-node-runtimepython-node-runtimepython-node-runtimegolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:eb64116-pythonRun
All tags pushed for this build
About Multi-Architecture Support
eb64116-python) is a multi-arch manifest supporting both amd64 and arm64eb64116-python-amd64) are also available if needed