Add IATA code as Airport label on zoom 12-14#56
Add IATA code as Airport label on zoom 12-14#56CharliePlett wants to merge 4 commits intoOpenHistoricalMap:stagingfrom
Conversation
Added IATA code as Airport label beside the icon on zooms 12 to 14. If no IATA available then defaults to ICAO.
Add IATA code as Airport label
|
If this gets approved then the icao= and iata= would need to be added to the vtiles for this to take effect. |
There was a problem hiding this comment.
This appears to drop the Airport icon entirely. Is that intentional?
I'm looking at SFO, https://localhost:8888/#13/37.62525/-122.38144, using our current version of staging and one to three airplanes appear from zoom ~10-14. I don't see any airplanes using your branch. I also don't see any IATA code; the only text that appears relates to taxiways and "San Francisco International Airport", and those begin to display at zoom 13.
Our staging branch:
Your staging branch:
|
Seems exposing the data is still pending in OpenHistoricalMap/issues#1314 |
|
I'm pretty sure the icon was showing when I created the pull request. Did something else change over time? |
|
I cloned your repo and am running your staging branch directly. I'd suspect that dropping
is the cause. |
|
Can you fix it? |
|
I messed up and accidentally moved my latest cemeteries commit into this pull request. |
The tiles should be ready for this change now.
I think the issue is that you cut these PRs from your copy of the staging branch. Whenever you make a fork, you should create a branch off of the default branch for anything you want to PR. Otherwise, your PRs get intermingled by accident. Unfortunately it isn’t possible to fix this from our end, so either everything needs to be in good shape to merge (even if unrelated), or you need to close the PR and open a new one with a different branch. |
|
It should be in good shape to merge. If not, then I'll do whatever needs to be done. |
| "filter": ["==", ["get", "type"], "aerodrome"], | ||
| "layout": { | ||
| "icon-image": "airport-18", | ||
| "icon-size": ["interpolate", ["linear"], ["zoom"], 10, 1.2, 14, 1.5], |
There was a problem hiding this comment.
Was this deletion intentional? Without it, airport icons would be smaller than before.
There was a problem hiding this comment.
I don't think it was intentional, but it's been a few months since I did that, so I'm not sure.
| "text-font": ["OpenHistorical"]} | ||
| "icon-offset": [-1.0, 0], | ||
| "text-font": ["OpenHistorical"], | ||
| "text-field": ["coalesce", ["get", "iata"], ["get", "icao"]], |
There was a problem hiding this comment.
Most smaller airports have a national code (like FAA LID in the U.S.) but not an international code. This was also true before the international codes were standardized. The tiles expose the national code as ref=*. Can we have that as a fallback, if not further up in the list?
There was a problem hiding this comment.
That would be good to have a fallback, I didn't realize it gave other airport codes at that time.
3 participants
This adds the iata= and icao= as the airport label beside the icon on zoom levels 12 to 14.