[compot-dev]

Test only, no app change, no version bump.

RtspSessionTest.heartbeatWhilePlayingStopsWithTheSlot failed once in 7 local runs (assertTrue(sent >= 2)): UdpHeartbeat counts a heartbeat after send() returns, so the test can receive the second 01 01 before the count reaches 2. The app is right to count only what was sent; the test now waits up to 2 s for the count.

Checked locally in compot/android:2026.10: testDebugUnitTest + lintDebug green; the test alone 15/15 with --rerun.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Stabilize the RTSP heartbeat count test

🧪 Tests 🕐 Less than 10 minutes

AI Description

• Wait up to two seconds for the heartbeat count after receiving two UDP packets.
• Preserve the existing checks that heartbeats run during playback and stop with the session.

Diagram

graph TD
  Receive["Receive two packets"] --> Read["Read heartbeat stats"] --> Ready{"Count reached two?"}
  Ready -->|No, before deadline| Wait["Sleep 10 ms"] --> Read
  Ready -->|Yes or timeout| Assert["Assert heartbeat state"] --> Stop["Stop session"]

Loading

High-Level Assessment

Bounded polling is appropriate for this test: it accommodates the interval between UDP delivery and the post-send count update without changing production accounting. A synchronization hook would add production complexity for a test-only race.

Files changed (1) +6 / -0

Tests (1) +6 / -0

RtspSessionTest.javaWait for the heartbeat count before asserting +6/-0

Wait for the heartbeat count before asserting

• After receiving two heartbeat datagrams, the test polls heartbeat statistics every 10 ms for up to two seconds. This avoids asserting before the sender increments its post-send count; the running and stop checks remain in place.

android/app/src/test/java/com/openipc/decoder/RtspSessionTest.java

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can see how risky a PR is at a glance with blast radius labels

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗