Repository navigation
web: the gk7205v200 family loads its -nor U-Boot, not the 2016.11 universal - #159
Merged
Merged
Conversation
…versal The CLI has taken u-boot-<soc>-nor.bin (OpenIPC/u-boot, 2022.10) for gk7202v300, gk7205v200, gk7205v300 and gk7605v100 since they joined PER_FLASH_TYPE_UBOOT; the Web UI still loaded their -universal image, the 2016.11 build. That U-Boot does not scan the flash: once its environment is wiped it falls back to the 8 MB slots, which is how a 16 MB ultimate camera ended in "VFS: Unable to mount root fs" in OpenIPC/firmware#2646. The -universal images are to be retired. They join the Web UI's -nor list, which also turns on SPL boundary detection for them, as `defib burn` always does: the four published -nor images end their SPL at 0x4800, inside the profiles' 0x6000. The release-asset fixtures that used gk7205v300's -universal image as a plain example now name its -nor one.
PR Summary by QodoLoad NOR U-Boot for the gk7205v200 family in the Web UI
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI has taken
u-boot-<soc>-nor.bin(OpenIPC/u-boot, 2022.10) for gk7202v300, gk7205v200, gk7205v300 and gk7605v100 since they joinedPER_FLASH_TYPE_UBOOT. The Web UI still loaded their-universalimage, the 2016.11 build.That U-Boot does not scan the flash. Once its environment is wiped it falls back to the 8 MB slots, which is how a 16 MB ultimate camera ended in
VFS: Unable to mount root fsin OpenIPC/firmware#2646. The-universalimages are to be retired fromlatest.The four SoCs join the Web UI's
-norlist. That list also turns on SPL boundary detection for them, asdefib burnalways does: the four published-norimages end their SPL at 0x4800, inside the profiles' 0x6000. The release-asset fixtures that used gk7205v300's-universalimage as a plain example now name its-norone.node --test web/protocol.test.js web/profile-parity.test.js: 93 passed.