Repository navigation
majestic-fonts: Ubuntu Font Licence, and a licence file legal-info collects - #2710
Merged
Merged
Conversation
…llects The package declared MIT and a LICENSE file it did not have. Both were wrong, and neither was ever noticed: with no version, Buildroot gives the package no source name, treats it as part of Buildroot itself, and its legal-info skips licence collection. So `make legal-info` did not fail. It recorded MIT for this font on 102 images and saved no licence text. The font is Ubuntu Mono. UbuntuMono-Regular.ttf, named "OpenIPC Mono" inside, has 170 mapped glyphs, and every outline matches upstream Ubuntu Mono Regular point for point (google/fonts ufl/ubuntumono). Upstream's name table says "Copyright 2011 Canonical Ltd. Licensed under the Ubuntu Font Licence 1.0". - LICENSE = UFL-1.0, and files/LICENSE carries that copyright line and the licence, verbatim from canonical/Ubuntu-fonts LICENCE.txt; - the package is a local-site package versioned 0.12, the font's own version, so legal-info collects the file. The custom extract step goes, because the local method copies the same directory; - majestic-fonts.hash pins the licence file. What lands on a camera is unchanged: the package still installs one file, /usr/share/fonts/truetype/UbuntuMono-Regular.ttf, byte-identical (sha256 ea790010...e49d27e before and after).
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
October 28, 2026 08:42
PR Summary by QodoCorrect majestic-fonts licence and collect it in legal-info
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
The Ubuntu Font Licence wants the notice and the licence with every copy of the font. The image is a copy, so the text now goes beside it as /usr/share/fonts/truetype/UbuntuMono-Regular.LICENSE: 4860 bytes, about 2.1 KB once xz-compressed. The font file itself is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised by the Qodo review on #2705:
majestic-fontsdeclares a licence file it does not ship. The finding was right about the file and wrong about the symptom. Nothing fails. The licence was simply never collected, and the licence it named was wrong.What was wrong
MAJESTIC_FONTS_LICENSE = MIT. The font is Ubuntu Mono, which is under the Ubuntu Font Licence 1.0.MAJESTIC_FONTS_LICENSE_FILES = LICENSE, butfiles/has only the.ttf.make legal-infopassed anyway. With no_VERSION, Buildroot leaves_SOURCEempty, and its legal-info rule skips licence collection for such packages ("Packages without a source are assumed to be part of Buildroot"). So on all 102 defconfigs that enable this package, the manifest said MIT and no licence text was saved.Provenance
UbuntuMono-Regular.ttfis named "OpenIPC Mono" inside. Of its 170 mapped glyphs, every one has the same outline, point for point, as upstream Ubuntu Mono Regular (google/fontsufl/ubuntumono/UbuntuMono-Regular.ttf). Upstream's copyright field reads "Copyright 2011 Canonical Ltd. Licensed under the Ubuntu Font Licence 1.0". The licence text comes verbatim fromcanonical/Ubuntu-fontsLICENCE.txt, which is identical to theUFL.txtingoogle/fonts.Change
LICENSE = UFL-1.0, and a newfiles/LICENSEholding the Canonical copyright line and the licence.SITE_METHOD = local+VERSION = 0.12(the font's own version string). The customEXTRACT_CMDSgoes, because the local method copies the same directory.majestic-fonts.hashpinsLICENSE./usr/share/fonts/truetype/UbuntuMono-Regular.LICENSE, because the UFL wants it with every copy and the image is a copy. It is 4860 bytes, about 2.1 KB once xz-compressed.Evidence
This changes no camera's behaviour. The font file is byte-identical to before. The only addition is a text file nothing reads, and the board builds here measure its size against each flash cap. The evidence is from the build tree (
fh8852v100_lite):The one remaining warning is Buildroot's standard one for local packages.
Not done here: the font's own name-table copyright field still reads
-. The stand-alone licence file now carries the notice, which is one of the ways the UFL accepts.