[widgetii]

Four commits.

1. cmd: sf builds on the HiSFC350 boards fixes a bug unrelated to the split layout. CMD_SF depended on DM_SPI_FLASH || SPI_FLASH || FMC_SPI_NOR, but not HISFC350_SPI_NOR. So olddefconfig drops the CMD_SF=y from openipc_config on every HiSFC350 board: hi3516av100, hi3516dv100, hi3516cv100, hi3518av100, hi3518cv100, hi3518ev100, hi3515av100, hi3520av100, hi3520dv100 and hi3520dv200.

• Their u-boot-<soc>-nor.bin has no sf. The env still loads and the layout scan still finds the kernel, because both call the spi_flash API directly. But bootcmd's sf probe; sf read fails, bootm finds no image, and the board resets until the boot limit leaves it at the prompt.
• In qemu-hisilicon, the published u-boot-hi3516av100-nor.bin (b1e0950) does exactly that, even on a fixed-slot image.
• The HiSFC350 driver provides the spi_flash_probe() and ops cmd/sf.c calls, so sf builds against it unchanged.

2–4. CONFIG_OPENIPC_NOR_SPLIT for families whose kernels now find the split layout from their device tree. Each board's misc_init_r() now sets verify=n before openipc_helper(), as #52 and #61 did. Fixed-slot cameras boot as before, and the NAND builds compile the split code out.

SoCs	configs	kernel
hi3516cv500, hi3516dv300, hi3516av300	hi3516cv500_config, hi3516dv300_config, hi3516av300_config	OpenIPC/linux#142
hi3536dv100	hi3536dv100_config	OpenIPC/linux#143
hi3516av100, hi3516dv100	hi3516av100_config, hi3516dv100_config	OpenIPC/linux#144

NOR images, all inside the 256K boot area: cv500 205144, dv300/av300 205328, 36dv100 144216, av100/dv100 126236 bytes.

Tested in qemu-hisilicon with each family's lite build on its new kernel. hi3516cv500 runs on 16 MB flash, the other two on 8 MB.

Case	hi3516cv500	hi3536dv100	hi3516av100
split image: scan, root-less command line, kernel's split	yes, root on 31:4, login	yes, root on 31:4, login	yes, rootfs (mtd4) set as root
fixed-slot package	fixed mtdparts, root on 31:3	same	fixed mtdparts, mtd3 set as root
fwupd over TFTP from fixed slots	byte-identical, boots split	same	same
damaged kernel → fails its CRC → recovery	byte-identical, boots split	same	same

On hi3516av100, qemu-hisilicon's model stops the boot after the MTD probe, before root is mounted. It does that on either layout, and with the kernel OpenIPC ships today too. Not run on hardware.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Enable split NOR layouts on six HiSilicon boards and restore HiSFC350 sf

✨ Enhancement 🐞 Bug fix ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Enable split NOR detection on six boards whose kernels derive partitions from their device trees.
• Preserve fixed-slot boot behavior while enabling CRC verification for split images.
• Restore the sf command on HiSFC350 boards so boot commands can read flash.

Diagram

graph TD
  Config["Board configs"] --> Init["Board initialization"] --> Layout{"NOR layout"} --> Split["Split image"] --> DT["Kernel device tree"]
  Layout --> Fixed["Fixed slots"]
  Command["CMD_SF dependency"] --> Driver["HiSFC350 driver"]

Loading

High-Level Assessment

The per-board opt-in matches the kernels that support split partitions without changing other boards or NAND behavior. Reordering initialization uses the existing scan, and extending CMD_SF's dependency directly addresses the missing command; a global layout change or new flash-command implementation would add unnecessary risk.

Files changed (12) +35 / -6

Enhancement (5) +10 / -5

board.cSet verification default before the av100 layout scan +2/-1

Set verification default before the av100 layout scan

• Moves verify=n ahead of openipc_helper() so the scan can clear it for split images and retain it for fixed-slot images.

board/hisilicon/hi3516av100/board.c

hi3516av300.cSet verification default before the av300 layout scan +2/-1

Set verification default before the av300 layout scan

• Moves verify=n ahead of openipc_helper(), allowing split-image CRC checks without changing the fixed-slot default.

board/hisilicon/hi3516av300/hi3516av300.c

hi3516cv500.cSet verification default before the cv500 layout scan +2/-1

Set verification default before the cv500 layout scan

• Moves verify=n ahead of openipc_helper(), allowing the split-image path to enable CRC verification.

board/hisilicon/hi3516cv500/hi3516cv500.c

hi3516dv300.cSet verification default before the dv300 layout scan +2/-1

Set verification default before the dv300 layout scan

• Moves verify=n ahead of openipc_helper() so split-image handling can clear the setting before boot.

board/hisilicon/hi3516dv300/hi3516dv300.c

board.cSet verification default before the dv100 layout scan +2/-1

Set verification default before the dv100 layout scan

• Moves verify=n ahead of openipc_helper(), preserving the fixed-slot default while permitting split-image verification.

board/hisilicon/hi3536dv100/board.c

Bug fix (1) +1 / -1

KconfigAllow sf with HiSFC350 SPI NOR +1/-1

Allow sf with HiSFC350 SPI NOR

• Adds HISFC350_SPI_NOR to CMD_SF's dependencies. This prevents olddefconfig from dropping an explicitly enabled sf command on HiSFC350 boards.

cmd/Kconfig

Other (6) +24 / -0

hi3516av100_configEnable split NOR handling for hi3516av100 +4/-0

Enable split NOR handling for hi3516av100

• Opts the board into CONFIG_OPENIPC_NOR_SPLIT for kernels that partition firmware using their device tree.

openipc/hi3516av100_config

hi3516av300_configEnable split NOR handling for hi3516av300 +4/-0

Enable split NOR handling for hi3516av300

• Opts the board into CONFIG_OPENIPC_NOR_SPLIT for the hi3516cv500-family kernel layout.

openipc/hi3516av300_config

hi3516cv500_configEnable split NOR handling for hi3516cv500 +4/-0

Enable split NOR handling for hi3516cv500

• Opts the board into CONFIG_OPENIPC_NOR_SPLIT for its kernel's device-tree-driven firmware partitions.

openipc/hi3516cv500_config

hi3516dv100_configEnable split NOR handling for hi3516dv100 +4/-0

Enable split NOR handling for hi3516dv100

• Opts the board into CONFIG_OPENIPC_NOR_SPLIT for the hi3516av100-family kernel layout.

openipc/hi3516dv100_config

hi3516dv300_configEnable split NOR handling for hi3516dv300 +4/-0

Enable split NOR handling for hi3516dv300

• Opts the board into CONFIG_OPENIPC_NOR_SPLIT for the hi3516cv500-family kernel layout.

openipc/hi3516dv300_config

hi3536dv100_configEnable split NOR handling for hi3536dv100 +4/-0

Enable split NOR handling for hi3536dv100

• Opts the board into CONFIG_OPENIPC_NOR_SPLIT for its kernel's device-tree-driven firmware partitions.

openipc/hi3536dv100_config

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Recovery scripts cannot flash full images ✓ Resolved

Description

Enabling the split update command makes fwwrite require ${fwsize}, but firmware_scan()
initializes that value only after openipc_helper() has executed recovery scripts. On any of the
six newly enabled NOR boards with a fresh environment, a script.txt that runs fwupd and
downloads a whole-firmware image reaches the size guard without fwsize, so the erase and write
commands do not run.

Code

openipc/hi3516cv500_config[23]

+CONFIG_OPENIPC_NOR_SPLIT=y

Evidence

All six added split configurations select the fwupd and fwwrite definitions that test
${fwsize}. Recovery gives script.txt precedence and executes it before the only normal
assignment of fwsize in the subsequent scan; with a fresh environment, the guard prevents
flashing.

openipc/hi3516cv500_config[20-23]
openipc/hi3516av100_config[46-49]
openipc/hi3536dv100_config[39-42]
include/configs/openipc-common.h[204-222]
common/openipc.c[533-568]
common/openipc.c[576-583]
common/openipc.c[819-829]
common/openipc.c[1084-1113]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
On newly enabled split-NOR boards, recovery `script.txt` may run `fwupd` before `firmware_scan()` sets `fwsize`, preventing whole-image flashing.
## Fix Focus Areas
- common/openipc.c[1084-1113]
- common/openipc.c[819-829]
- include/configs/openipc-common.h[204-222]
## Recommended Fix
Make the split whole-image update command usable during removable-media recovery by deriving and setting a valid firmware-area size from the probed flash and firmware start before executing recovery scripts. Preserve the existing post-recovery layout scan and its RAM-only updates.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can choose which labels appear on a finding, and whether they show icons or text

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗