SetupUtils: pass chmod arguments to Runtime.exec as an array - #1126
Open
vharseko wants to merge 1 commit into
Open
SetupUtils: pass chmod arguments to Runtime.exec as an array#1126vharseko wants to merge 1 commit into
vharseko wants to merge 1 commit into
Conversation
Runtime.exec(String) splits the concatenated command on whitespace, so a deployment URI containing spaces would be handed to /bin/chmod as several operands. Build the command as a String[] instead. Closes CodeQL alert java/concatenated-command-line https://github.com/OpenIdentityPlatform/OpenAM/security/code-scanning/394
vharseko
added
java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime.exec(String)splits the concatenated command on whitespace, so a deployment URI containing spaces would be handed to/bin/chmodas several operands. Build the command as aString[]instead.Closes CodeQL alert
java/concatenated-command-line: https://github.com/OpenIdentityPlatform/OpenAM/security/code-scanning/394Only affects the local ssoadm tools installer (
com.sun.identity.tools.bundles.Main); no shell is involved either way, so this is hygiene rather than a security fix.