Repository navigation
fix: report sub-minute job timeouts in seconds - #9547
Closed
charan-rathore wants to merge 1 commit into
Closed
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
Author
|
Closing since this has sat without activity. Glad to reopen if someone wants to take it forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Job timeouts under a minute were printed as "0 minutes" because the message used integer division. A 3 second timeout now reads "3 seconds". Fixes #9527.
Changes
format_timeouthelper injob_runner.pythat reports seconds below 60 and minutes otherwise.test_format_timeout.py(8 formatter cases) and an assertion intest_job_flow.pythat a real 3 second job prints the timeout in seconds.Testing
syft-jobsuite: 123 tests pass. The repo pre-commit hooks pass on the three changed files.job_runner.py(different problems), so one of us may need a small rebase around the imports.Asana task
N/A, external contribution.