Skip to content

fix: login error outside Colab now says what to do #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koenvanderveen merged 2 commits into from
Oct 7, 2026
Merged

fix: login error outside Colab now says what to do #9550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3d1b8
fix: point the token_path login error at docs/auth.md
atlaie Oct 2, 2026
068c3df
Merge branch 'dev' into fix/auth-error-points-to-docs
koenvanderveen Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion syft/sync/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ def _resolve_login_params(
token_path = token_path or settings.token_path
if not token_path:
raise NotImplementedError(
"Jupyter login is only supported with a token path"
"Running outside Colab: pass token_path=... to login_do()/login_ds(). "
"See docs/auth.md to create a token (about 15 minutes)."
)
if email is None:
raise ValueError("Email is required for Jupyter login")
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/without_unit_coverage/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def test_login_ds_missing_token_path_raises(monkeypatch):
"""Test that login_ds raises error when token_path is missing in Jupyter env."""
# Unset the env var so the test can verify the error is raised
monkeypatch.delenv("SYFT_TOKEN_PATH", raising=False)
with pytest.raises(NotImplementedError, match="token path"):
with pytest.raises(NotImplementedError, match="token_path"):
sy.login_ds(
email="test@test.com",
token_path=None,
Expand All @@ -192,7 +192,7 @@ def test_login_do_missing_token_path_raises(monkeypatch):
"""Test that login_do raises error when token_path is missing in Jupyter env."""
# Unset the env var so the test can verify the error is raised
monkeypatch.delenv("SYFT_TOKEN_PATH", raising=False)
with pytest.raises(NotImplementedError, match="token path"):
with pytest.raises(NotImplementedError, match="token_path"):
sy.login_do(
email="test@test.com",
token_path=None,
Expand Down
Loading