Skip to content

Fix GPU S2N validation: shape mismatch crash and inverted threshold logic #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlib merged 2 commits into from
May 18, 2026
+6 −4
Merged

Fix GPU S2N validation: shape mismatch crash and inverted threshold logic #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e9263
Initial plan
Copilot May 18, 2026
b5405a1
Fix GPU S2N validation: shape mismatch and inverted threshold logic
Copilot May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openpiv/gpu/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ def _validate_fields(self, u, v, dp_u, dp_v):
if self.num_validation_iters == 0:
return u, v, val_locations
if "s2n" in self.validation_method:
s2n_ratio = self._corr_gpu.s2n_ratio
s2n_ratio = self._corr_gpu.s2n_ratio.reshape(u.shape)

# Create the validation object.
self._validation_gpu = Validation(
Expand Down
6 changes: 4 additions & 2 deletions openpiv/gpu/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,8 +448,10 @@ def _s2n_validation(self, s2n_ratio):
return
s2n_tol = log10(self.s2n_tol)

sig2noise_tol = s2n_ratio / DTYPE_f(s2n_tol)
self.val_locations = _local_validation(sig2noise_tol, 1, self.val_locations)
# Mark invalid where s2n_ratio < s2n_tol, i.e. (s2n_tol - s2n_ratio) > 0.
self.val_locations = _local_validation(
DTYPE_f(s2n_tol) - s2n_ratio, 0, self.val_locations
)

def _mask_val_locations(self):
"""Removes masked locations from the validation locations."""
Expand Down
2 changes: 1 addition & 1 deletion openpiv/test/gpu/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_validation_median_num_validation_locations(validation_gpu, peaks_reshap
def test_validation_s2n_validation(validation_gpu, s2n_ratio):
tol = log10(validation.S2N_TOL)

val_locations = validation._local_validation(s2n_ratio / tol, 1).get()
val_locations = validation._local_validation(DTYPE_f(tol) - s2n_ratio, 0).get()
validation_gpu._s2n_validation(s2n_ratio)
val_locations_gpu = validation_gpu.val_locations.get()

Expand Down
Loading