Expanding firmware_update to pull data. Added inventory test. - #468
Merged
Merged
Conversation
CourtneyDrant
requested review from
chrysh,
leongross,
rusty1968 and
wmaroneAMD
September 11, 2026 22:06
chrysh
reviewed
Sep 15, 2026
chrysh
reviewed
Sep 15, 2026
chrysh
approved these changes
Sep 15, 2026
chrysh
left a comment
chrysh
left a comment
Contributor
There was a problem hiding this comment.
Only two nits, but otherwise it's ready to merge
chrysh
reviewed
Sep 15, 2026
CourtneyDrant
force-pushed
the
fw-update-inventory
branch
from
September 17, 2026 18:28
5b703c8 to
a5426bf
Compare
CourtneyDrant
force-pushed
the
fw-update-inventory
branch
from
September 17, 2026 18:29
a5426bf to
318d473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a FW payload to firmware_update tests to stress FD as an initiator. Added a test that explicitly focuses on Inventory commands. Inventory commands do not invoke the state machine and are limted to GetFirmwareParameters and QueryDeviceIdentifiers.