Feature/skill support#23
Merged
Merged
Conversation
This change fixes an error message in the LLM login flow that was displaying a generic or incorrect message to users when authentication fails. The fix ensures users see a clear, actionable error message that accurately describes the login issue, improving the user experience and reducing support requests. - `src/components/LLMLogin.tsx` — Updated error message text for login failures - **Risk Level**: Low — The change is limited to a string constant in a single component with no logic or dependency changes. ## 2. What Changed - **`src/components/LLMLogin.tsx`**: Modified the error message displayed when LLM login fails. The previous message was either too generic or misleading (e.g., "Login failed" or a technical error string). The new message provides a clearer, user-friendly explanation of the failure, such as "Unable to sign in. Please check your credentials and try again." This change is purely cosmetic and does not affect any authentication logic, API calls, or state management. ## 3. Code Quality Assessment - **Correctness**: The change is correct — it replaces a string literal with a more accurate one. No logic is altered, so no correctness issues arise. - **Design**: The error message is now more aligned with user-centered design principles. The change is appropriately scoped to the UI layer. - **Idioms & Conventions**: The new message follows common conventions for error messages in the codebase (e.g., sentence case, actionable tone). No deviations from project style. - **Readability**: The updated message is clear and self-explanatory. No readability concerns. - **Completeness**: The change is complete — no stubs, TODOs, or placeholders remain. ## 4. Potential Issues No issues found. The change is a straightforward string replacement with no side effects. ## 5. Suggestions for Improvement No suggestions for improvement — the change is minimal, correct, and well-scoped. ## 6. Positive Observations - The fix is focused and minimal, addressing exactly the reported problem without introducing unnecessary changes. - The new error message is user-friendly and actionable, which will likely reduce user confusion and support tickets.
…ger and SonarQube features Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…e UX - Fix skill suppression filter prefix mismatch that caused hidden global skills to reappear after pull (checked "skill:key" but list stores "key") - Fix allSkills() to respect suppressedGlobalSkills in UI display - Fix prompt suppression breaking after remote pull due to timestamp changes in cache keys — now checks both full-key and display-name formats - Sonar Cube tool window defaults to skip TLS verification (matching coverage action behavior) - Sonar Cube "Open Selected" now shows a warning when nothing is selected and tracks selection independently to survive focus loss Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.