docs: add missing zod install step to typescript-sdk and agent-migration skills#70
docs: add missing zod install step to typescript-sdk and agent-migration skills#70Ritik92 wants to merge 1 commit into
Conversation
…ion skills The tool() examples in both skills import from `zod`, but neither skill's install section mentioned installing it, so anyone copy-pasting the documented patterns hit `Cannot find module 'zod'`. Closes OpenRouterTeam#16 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![perry-the-pr-maintainer[bot]](https://avatars.githubusercontent.com/in/3387167?s=60&v=4){kind=small}
There was a problem hiding this comment.
Perry's Review
Adds the missing npm install zod step to two skill docs whose tool() examples import from zod but never told readers to install it.
Verdict: ✅ LGTM
Details
Risk: 🟢 Low
CI: all passing ✅
Findings: none — verified both skills' tool() examples actually import zod (typescript-sdk: lines 415/1140/1216; agent-migration: lines 134/174/261/285), confirmed neither skill ships a package manifest, and confirmed the READMEs only document gh skill install so no README change was needed. The install step is placed correctly in both files (before the "uninstall @openrouter/sdk" note in agent-migration; alongside the other package installs in typescript-sdk).
Research: n/a (trivial tier)
Security: no concerns — docs-only change, no secret patterns in the diff
Test coverage: n/a — documentation change, no code paths
Unresolved threads: none
Scope: first review (full)
Review: tier=trivial · model=claude-sonnet-latest · score=0.1
1 participant
Summary
Fixes #16. The
tool()examples in two skills import fromzod, but neither skill's install section mentioned installing it — so anyone copy-pasting the documented patterns hitCannot find module 'zod'with no indication an extra install step was needed.openrouter-typescript-sdk/SKILL.md— addnpm install zodto the Installation block (tool examples importzodat lines 412 / 1137 / 1213).openrouter-agent-migration/SKILL.md— add annpm install zodstep in Quick Migration → Step 1 (tool examples importzodat lines 128 / 168 / 255 / 279).Test plan
SKILL.mdinstall sections now listzodgh skill install, and neither skill ships apackage.jsonCloses #16
🤖 Generated with Claude Code