Skip to content

Restrict DCI sync and cached value access #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremi wants to merge 1 commit into
base: 19.0
Choose a base branch
from
+27 −2
Open

Restrict DCI sync and cached value access #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spp_cel_domain/security/ir.model.access.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_spp_data_value_user,spp.data.value user,model_spp_data_value,base.group_user,1,0,0,0
access_spp_data_value_user,spp.data.value base user disabled,model_spp_data_value,base.group_user,0,0,0,0
access_cel_rule_wizard_manager,access_cel_rule_wizard_manager,model_spp_cel_rule_wizard,spp_cel_domain.group_cel_domain_manager,1,1,1,0
access_cel_rule_wizard_metric_manager,access_cel_rule_wizard_metric_manager,model_spp_cel_rule_wizard_metric,spp_cel_domain.group_cel_domain_manager,1,0,1,1
access_cel_variable_category_viewer,access_cel_variable_category_viewer,model_spp_cel_variable_category,spp_cel_domain.group_cel_domain_viewer,1,0,0,0
Expand Down
2 changes: 2 additions & 0 deletions spp_dci_indicators/data/dci_sync.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<field name="binding_model_id" ref="base.model_res_partner" />
<field name="binding_view_types">list,form</field>
<field name="state">code</field>
<field name="group_ids" eval="[Command.link(ref('spp_cel_domain.group_cel_domain_manager'))]" />
<field name="code">
if records:
count = env["spp.dci.cel.fetcher"].sync_for_partners(records.ids)
Expand All @@ -28,6 +29,7 @@ if records:
<field name="name">DCI: Sync CEL metrics</field>
<field name="model_id" ref="base.model_res_partner" />
<field name="state">code</field>
<field name="user_id" ref="base.user_root" />
<field
name="code"
>env["spp.dci.cel.fetcher"].cron_sync_all_registrants()</field>
Expand Down
10 changes: 9 additions & 1 deletion spp_dci_indicators/models/dci_cel_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@

import logging

from odoo import api, models
from odoo import _, api, models
from odoo.exceptions import AccessError

_logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -92,6 +93,12 @@ def _dci_backed_variables(self):
]
)

@api.model
def _check_dci_sync_access(self):
"""Require CEL manager privileges before triggering outbound DCI sync."""
if not self.env.user.has_group("spp_cel_domain.group_cel_domain_manager"):
raise AccessError(_("Only CEL Domain Managers can sync DCI-backed CEL values."))
Comment on lines +97 to +100

@gemini-code-assist gemini-code-assist Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Odoo, when a method is executed in superuser mode (e.g., via .sudo()), self.env.su is set to True, but self.env.user remains the original user. If the original user does not belong to the CEL manager group, calling self.env.user.has_group(...) will return False and raise an AccessError, even though the environment is running with elevated privileges. To ensure that sudo() works correctly and doesn't unexpectedly fail with an access error, you should explicitly bypass this check when self.env.su is True.

Suggested change
def _check_dci_sync_access(self):
"""Require CEL manager privileges before triggering outbound DCI sync."""
if not self.env.user.has_group("spp_cel_domain.group_cel_domain_manager"):
raise AccessError(_("Only CEL Domain Managers can sync DCI-backed CEL values."))
@api.model
def _check_dci_sync_access(self):
"""Require CEL manager privileges before triggering outbound DCI sync."""
if not self.env.su and not self.env.user.has_group("spp_cel_domain.group_cel_domain_manager"):
raise AccessError(_("Only CEL Domain Managers can sync DCI-backed CEL values."))


@api.model
def sync_for_partners(self, partner_ids, variables=None):
"""Fetch + cache all DCI-backed variables for the given partners.
Expand All @@ -100,6 +107,7 @@ def sync_for_partners(self, partner_ids, variables=None):
manager's precompute path, which calls this fetcher and stores the result
in spp.data.value.
"""
self._check_dci_sync_access()
partner_ids = list(partner_ids or [])
if not partner_ids:
return 0
Expand Down
15 changes: 15 additions & 0 deletions spp_dci_indicators/tests/test_dci_cel_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

from unittest.mock import patch

from odoo import Command
from odoo.exceptions import AccessError
from odoo.tests import TransactionCase, tagged

from odoo.addons.spp_dci.schemas.constants import RegistryType
Expand Down Expand Up @@ -151,6 +153,19 @@ def test_sync_for_partners_caches_values(self):
def test_sync_for_partners_empty_is_noop(self):
self.assertEqual(self.Fetcher.sync_for_partners([]), 0)

def test_sync_for_partners_requires_cel_manager(self):
plain_user = self.env["res.users"].create(
{
"name": "DCI Sync Plain User",
"login": "dci_sync_plain_user@example.test",
"group_ids": [Command.set([self.env.ref("base.group_user").id])],
}
)
with self.assertRaises(AccessError):
self.Fetcher.with_user(plain_user).sync_for_partners(
[self.partner.id], variables=self.var_is_alive
)

def test_dci_backed_variables_excludes_plain_providers(self):
plain = self.env["spp.data.provider"].create({"name": "Plain", "code": "plain_excl_t"})
self.env["spp.cel.variable"].create(
Expand Down
Loading