Skip to content

feat(change_request): redesign Create Group & Add Member CRs + review-page fixes (#876 #871)#242

Open
emjay0921 wants to merge 27 commits into
19.0from
feat/876-create-group-cr-redesign
Open

feat(change_request): redesign Create Group & Add Member CRs + review-page fixes (#876 #871)#242
emjay0921 wants to merge 27 commits into
19.0from
feat/876-create-group-cr-redesign

feat(change_request_v2): Add Member CR selects an existing member (#871)

adbcc7f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 17, 2026 in 0s

71.53% (+0.02%) compared to c660896

View this Pull Request on Codecov

71.53% (+0.02%) compared to c660896

Details

Codecov Report

❌ Patch coverage is 86.96398% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.53%. Comparing base (c660896) to head (adbcc7f).
⚠️ Report is 106 commits behind head on 19.0.

Files with missing lines Patch % Lines
spp_change_request_v2/details/create_group.py 85.25% 23 Missing ⚠️
spp_change_request_v2/wizards/create_wizard.py 7.14% 13 Missing ⚠️
spp_change_request_v2/details/add_member.py 76.74% 10 Missing ⚠️
spp_change_request_v2/strategies/create_group.py 93.80% 7 Missing ⚠️
spp_mis_demo_v2/models/mis_demo_generator.py 0.00% 7 Missing ⚠️
spp_change_request_v2/models/change_request.py 89.83% 6 Missing ⚠️
spp_change_request_v2/strategies/change_hoh.py 82.14% 5 Missing ⚠️
...pp_change_request_v2/models/change_request_type.py 87.50% 2 Missing ⚠️
...e_request_v2/wizards/create_group_member_wizard.py 97.43% 2 Missing ⚠️
spp_change_request_v2/strategies/add_member.py 96.29% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #242      +/-   ##
==========================================
+ Coverage   71.50%   71.53%   +0.02%     
==========================================
  Files        1001     1004       +3     
  Lines       58626    59883    +1257     
==========================================
+ Hits        41921    42836     +915     
- Misses      16705    17047     +342     
Files with missing lines Coverage Δ
spp_change_request_v2/__manifest__.py 0.00% <ø> (ø)
spp_change_request_v2/details/change_hoh.py 100.00% <100.00%> (+35.71%) ⬆️
spp_change_request_v2/wizards/__init__.py 100.00% <100.00%> (ø)
spp_change_request_v2/strategies/add_member.py 93.87% <96.29%> (+2.44%) ⬆️
...pp_change_request_v2/models/change_request_type.py 69.41% <87.50%> (+1.87%) ⬆️
...e_request_v2/wizards/create_group_member_wizard.py 97.43% <97.43%> (ø)
spp_change_request_v2/strategies/change_hoh.py 84.61% <82.14%> (-4.86%) ⬇️
spp_change_request_v2/models/change_request.py 84.66% <89.83%> (+0.30%) ⬆️
spp_change_request_v2/strategies/create_group.py 93.18% <93.80%> (-0.94%) ⬇️
spp_mis_demo_v2/models/mis_demo_generator.py 67.40% <0.00%> (+1.49%) ⬆️
... and 3 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.