Skip to content

fix: normalize binary cache path so the save step works #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhvrc merged 3 commits into from
Jun 25, 2026
Merged

fix: normalize binary cache path so the save step works #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c4aa0f
fix: cache compiled binary instead of recompiling each run
hhvrc Jun 25, 2026
90ef2dd
fix: normalize binary cache path so save works for uses: ./
hhvrc Jun 25, 2026
8faabdb
Merge remote-tracking branch 'origin/master' into fix/cache-path-norm…
hhvrc Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/fix-cache-path.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
kind: fixed
---
Use a normalized absolute path for the binary cache so the save step works for `uses: ./` self-invocation (github.action_path ends in `/.`, which actions/cache rejected as an invalid pattern, silently skipping the save)
5 changes: 4 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,15 @@ runs:
h=$(find . -type f \( -name '*.go' -o -name 'go.mod' -o -name 'go.sum' \) \
-print0 | sort -z | xargs -0 sha256sum | sha256sum | awk '{print $1}')
echo "hash=$h" >> "$GITHUB_OUTPUT"
# Emit a normalized absolute path: github.action_path ends in "/." for
# `uses: ./`, and actions/cache rejects any path containing "/./".
echo "binpath=$(pwd -P)/release-tool" >> "$GITHUB_OUTPUT"

- name: Restore release-tool binary
id: cache-bin
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: ${{ github.action_path }}/release-tool
path: ${{ steps.srchash.outputs.binpath }}
key: release-tool-${{ runner.os }}-${{ runner.arch }}-go${{ inputs.go-version }}-${{ steps.srchash.outputs.hash }}

- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
Expand Down
Loading