Skip to content

Fixing GetMaxFrame() to fix tiny float overshoot#1070

Merged
jonoomph merged 1 commit intodevelopfrom
black-frame
May 8, 2026
Merged

Fixing GetMaxFrame() to fix tiny float overshoot#1070
jonoomph merged 1 commit intodevelopfrom
black-frame

Conversation

@jonoomph
Copy link
Copy Markdown
Member

@jonoomph jonoomph commented May 8, 2026

Fixing GetMaxFrame() to fix tiny float overshoot, causing occasional black frames at the end of an export. For example, it might have concluded that we had 505.00001 frames, and this would then be converted later to 506 with ceil().

…black frames at the end of an export. For example, it might have concluded that we had 505.00001 frames, and this would then be converted later to 506 with ceil().
@jonoomph
Copy link
Copy Markdown
Member Author

jonoomph commented May 8, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.12%. Comparing base (fbc37e2) to head (6ccb526).

Files with missing lines Patch % Lines
src/Timeline.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1070      +/-   ##
===========================================
+ Coverage    70.11%   70.12%   +0.01%     
===========================================
  Files          241      241              
  Lines        29059    29075      +16     
===========================================
+ Hits         20375    20390      +15     
- Misses        8684     8685       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonoomph jonoomph merged commit 204925c into develop May 8, 2026
13 checks passed
@jonoomph jonoomph deleted the black-frame branch May 8, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant