Merged
Conversation
Update FindFFmpeg.cmake to read component version defines from both version_major.h and version.h. Newer FFmpeg releases moved some version macros into version_major.h, which broke fallback detection when pkg-config did not provide component versions.
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1072 +/- ##
===========================================
+ Coverage 70.11% 70.28% +0.16%
===========================================
Files 241 241
Lines 29059 29497 +438
===========================================
+ Hits 20375 20732 +357
- Misses 8684 8765 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update FindFFmpeg.cmake to read component version defines from both version_major.h and version.h. Newer FFmpeg releases moved some version macros into version_major.h, which broke fallback detection when pkg-config did not provide component versions.
Fixes #947