Skip to content

Apply reader-side orientation metadata (i.e. rotate pixels before Clip)#1073

Open
jonoomph wants to merge 1 commit intodevelopfrom
source-rotation
Open

Apply reader-side orientation metadata (i.e. rotate pixels before Clip)#1073
jonoomph wants to merge 1 commit intodevelopfrom
source-rotation

Conversation

@jonoomph
Copy link
Copy Markdown
Member

@jonoomph jonoomph commented May 9, 2026

Apply reader-side orientation metadata and stabilize tracker stroke rendering

  • Move phone/video rotation metadata handling into readers with an internal clip compatibility mode for legacy projects. FFmpegReader now reports oriented dimensions, applies orientation to decoded frames, and preserves old JSON behavior through reader_orientation_mode.

  • Also adjust tracker/object-detection stroke width for preview raster scaling so tracked boxes remain visible during clip scale animations.

…endering

- Move phone/video rotation metadata handling into readers with an internal clip compatibility mode for legacy projects. FFmpegReader now reports oriented dimensions, applies orientation to decoded frames, and preserves old JSON behavior through reader_orientation_mode.

- Also adjust tracker/object-detection stroke width for preview raster scaling so tracked boxes remain visible during clip scale animations.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 87.13450% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.42%. Comparing base (eb2411e) to head (0081cda).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/FFmpegReader.cpp 81.48% 10 Missing ⚠️
src/TrackedObjectBBox.cpp 67.74% 10 Missing ⚠️
src/Clip.cpp 95.00% 1 Missing ⚠️
src/effects/ObjectDetection.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1073      +/-   ##
===========================================
+ Coverage    70.28%   70.42%   +0.13%     
===========================================
  Files          241      241              
  Lines        29497    29656     +159     
===========================================
+ Hits         20732    20885     +153     
- Misses        8765     8771       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonoomph
Copy link
Copy Markdown
Member Author

jonoomph commented May 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant