Repository navigation
ci: pin build runners to ubuntu-24.04 - #72
Merged
Merged
Conversation
GitHub is rolling ubuntu-latest over to Ubuntu 26.04 (gcc 15.2). On that image the environment-check step fails to build the pinned MTL v26.09: MTL compiles with -Werror and gcc 15 reports -Wformat-truncation in lib/src/st2110/pipeline/st40_pipeline_rx.c, so every job that builds the toolchain (CI, CodeQL, Coverity, Daily Build, Pull Request) fails before reaching our code. Pin those jobs to ubuntu-24.04, the validated platform. Scorecard builds nothing and stays on ubuntu-latest. Also key the environment cache on the runner image (ImageOS) in addition to runner.os, which is only "Linux", so DPDK/MTL/FFmpeg binaries built on one Ubuntu release are never restored onto another.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #71 merged, CodeQL Scan and Continuous Integration on
devfailed in the Environment check step, before any project code was built. The scheduled Coverity and Daily Build jobs are affected the same way.Root cause
GitHub is rolling
ubuntu-latestover to Ubuntu 26.04 (gcc 15.2). The PR run of #71 still landed on Ubuntu 24.04 and passed; the post-merge runs landed on 26.04 and failed.On 26.04 the pinned MTL v26.09 no longer builds: MTL compiles with
-Werror, and gcc 15 reportsdevafter merge (CodeQL, CI)Changes
ubuntu-24.04— the validated platform per the README — for every job that builds the toolchain or the applications:ci.yml,codeql.yml,coverity.yml,daily_build.yml(build, AFL, libFuzzer) andpull_request.yml.scorecard.ymlbuilds nothing and stays onubuntu-latest.runner.os, which is onlyLinux, so DPDK/MTL/FFmpeg binaries built on one Ubuntu release could be restored onto another. A small step now reads the runner'sImageOS(e.g.ubuntu24) and appends it to both the restore and save keys.Notes for reviewers
v3environment cache has been saved ondevyet (the failing runs never reached the save step), so the new key costs no extra rebuild.-Wformat-truncationfor the MTL build); the image-aware cache key will then keep the two images' caches separate.Checklist
Code Quality
Testing
Review Readiness
Documentation
Security
PR Type
What kind of change does this PR introduce?