Add allowlist#625
Open
andrew-fleming wants to merge 7 commits into
Open
Conversation
Contributor
WalkthroughAdds a new ChangesAllowlist Contract and Test Infrastructure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #607
The original idea was to consolidate allowlist with blocklist (similar to ERC20Restricted). The reason it was dismissed from this design was because we would not be able to cleanly support using both in a single contract due to compiler limitations. The other idea with consolidation would be to have two different sets: one for allows and one for blocks; however, this forces users who just want one to import ledger state that won't be used. Finally, keeping them as separate modules allows for it be explicit: There shouldn't be any confusion if a contract is using an allow list or a block list
As an aside, it is the author's opinion that these are
securityprimitives; however, there is an argument that this belongs inaccesscontrol/Summary by CodeRabbit
Release Notes