feat(role-manager): enable full ENS with mainnet L1 fallback on testnets#127
Open
pasevin wants to merge 4 commits into
Open
feat(role-manager): enable full ENS with mainnet L1 fallback on testnets#127pasevin wants to merge 4 commits into
pasevin wants to merge 4 commits into
Conversation
Bump OZ UI/adapter floors to 003 and statically opt in to enableMainnetL1MissFallback so Sepolia rows resolve mainnet ENS names with the default cross-network disclaimer. Co-authored-by: Cursor <cursoragent@cursor.com>
Contract addresses in the sidebar picker were the last account-style display still using plain AddressDisplay. Use ResolvedAddressDisplay with per-contract networkId so reverse ENS applies consistently. Co-authored-by: Cursor <cursoragent@cursor.com>
The incidental bump to pnpm@11.12.0 caused pnpm/action-setup to fail during self-install with "Cannot use 'in' operator to search for 'integrity' in undefined". Revert to the main-branch packageManager pin. Co-authored-by: Cursor <cursoragent@cursor.com>
Bump @openzeppelin/ui-components to ^3.6.0 for showForwardResolutionSuccessAnnouncer. Add rich ENS preview below AddressField in role dialogs via AddressFieldWithResolvedPreview, with contract-runtime fallback for reverse resolution. Uses the real UIKit prop — no shim. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui-types/ui-utils3.3.0,ui-components3.5.0,ui-react3.2.0,ui-renderer3.3.0,adapter-evm2.3.0) and alignpnpm-workspace.yamloverrides to a singleui-types3.3.0 graph.NameResolverBridge(forward resolution inAddressField),ResolvedAddressDisplay+AddressNameResolutionProvider(reverse name + avatar), andenableNameResolutionon the Address Book widget.enableMainnetL1MissFallback: trueviaRUNTIME_CREATION_OPTIONSthreaded throughgetRuntime→RuntimeProvider.resolveRuntime, so Sepolia rows resolve mainnet ENS names with the default amber cross-network disclaimer.ENS coverage
Forward resolution (
NameResolverBridge→AddressField)AssignRoleDialog,TransferOwnershipDialog,TransferAdminDialogAddContractFormcontract-address inputs viaDynamicFormFieldenableNameResolution={true})Reverse resolution (
ResolvedAddressDisplay)ManageRolesDialogGhostAccountRow,GhostPendingTransfer)ContractSelector(per-contractnetworkId)Mainnet L1 fallback (003 opt-in)
RUNTIME_CREATION_OPTIONS— no user toggleshowCrossNetworkFallbackDisclaimeron)Intentionally excluded (not account addresses)
ChangeRowtransaction hash columnRoleNameDisplay/RoleIdentifiersTable(role identifier hashes, not wallets)Test plan
pnpm install(lockfile clean — no local-link contamination)pnpm --filter @openzeppelin/role-manager-app typecheckpnpm --filter @openzeppelin/role-manager-app lintpnpm --filter @openzeppelin/role-manager-app buildpnpm --filter @openzeppelin/role-manager-app test(1183 tests passed)vitalik.ethin an AddressField — forward resolution should resolve inlineenableNameResolutionis on