config: config CSS rework - #1137
Draft
Rakibei wants to merge 5 commits into
Draft
Conversation
Collaborator
|
My first reaction is that there is way too much padding between the elements. |
Collaborator
|
I agree with xiashtra, the amount of added padding here is going to significantly increase the scrolling required on an already massive page. In addition, I just want to confirm - this was tested in (I like the overall change in look and feel here, FWIW) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked a large part of the CSS for the Cactbot config.
The goal was to make it easier for the user to get an overview of the different configs sections.
Has the added benefit of adding a distinction between the different sections, as mentioned in issue #1120.
The pull request is technically ready but I would like hear some feedback so I am leaving it as a draft for now.