[VW-334] add missing cvssScore, cvssVector in extracted and pass to LLM, fix typo in remediation#149
Conversation
…ypo in remediation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates prompt strings used by ChangesMatch Prompt Text Updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/inbox/agent/match.ts`:
- Line 164: The template literal in the remediations log line is broken in
match.ts: the fallback for e.description is outside the interpolation, so the
prompt text becomes garbled. Fix the line in the remediation extraction loop by
moving the nullish-coalescing fallback inside the ${...} expression for
description, matching the existing linkedCveId pattern, so the generated string
cleanly falls back to "?" when e.description is nullish.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: be017ace-f59a-4026-b1bb-a4753e484372
📒 Files selected for processing (1)
src/features/inbox/agent/match.ts
0xcad
left a comment
There was a problem hiding this comment.
Approve with one note on change you can make
Jira ticket: https://northeastern-patch.atlassian.net/browse/VW-334 and https://northeastern-patch.atlassian.net/browse/VW-335
While Testing, I found a bug where updates to existing Vulnerability records were not working correctly. The issue was caused by cvssScore and cvssVector not being included in the renderCandidate function, preventing those extracted values from being passed to LLM for comparison during the update workflow
Summary by CodeRabbit