[VW-0] DeviceWithImage model, Devices Tables shows image status & DeviceDetails view#38
Merged
Merged
Conversation
timrcm
requested changes
Jun 26, 2026
| @@ -1,5 +1,5 @@ | |||
| from functools import wraps | |||
| from typing import Any, Callable, Literal, Optional, TypeVar | |||
| from typing import Any, Callable, Literal, Optional, TypeVar, Union | |||
| @@ -0,0 +1,140 @@ | |||
| import { useQuery } from "@tanstack/react-query"; | |||
Collaborator
There was a problem hiding this comment.
This is pretty shiny!
- Can we show something other than 'Uploaded' for containers?
- Also, when I add a VM that does not have an image yet, it still shows 'uploaded'; might want to check if vm_image_id is still null.
…ainer image is just an input now
timrcm
approved these changes
Jul 7, 2026
timrcm
left a comment
timrcm
left a comment
Collaborator
There was a problem hiding this comment.
This all looks solid, thanks!
| @@ -0,0 +1,140 @@ | |||
| import { useQuery } from "@tanstack/react-query"; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes: