Repository navigation
t4 screen & internet card fixes - #124
Merged
Merged
Conversation
… with nuch original mod's software
Member
|
Could I get you to remove the internet card changes? I'm working on a full fix for that as opposed to just removing the check. |
This reverts commit 129a430.
Author
|
Sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t4 screens apparently were supposed to display colors in RGB565 format, i. e. 16 bit per color. However, the screen color buffer was still packing background and foreground color pairs as 2 byte integers, which obviously led to overflowing issues and unusable screens.
Gpu's setDepth() method was also not modified properly, therefore it refused to set 16 bit color depth even on t4 gpus, which was also fixed.
Internet card now seems to restrict HTTP redirects, which breaks compatibility with the original mod. Many links used in OC's software, such as this github link, require redirect to work. This is why i removed
http.setInstanceFollowRedirects(false)call.