Fix Pathfinder csheet fixtures after Favored Class Bonus visibility change#7659
Merged
Merged
Conversation
…hange The Pathfinder Cleric/Paladin/Rogue integration tests started failing on master after 1439ee6 (PR PCGen#7658, issue PCGen#7478) made Favored Class Bonuses render on the character sheet: the LST change was correct, but the three csheet fixtures were not updated to match the new output. In cr_abilities_class.lst, PR PCGen#7658: - dropped VISIBLE:DISPLAY (DISPLAY_ONLY -> DEFAULT, so the abilities now export as well as show in the GUI) - added .SpecialQuality to the TYPE That moves the Bonus Hit Point / Bonus Skill Rank <ability_object> entries from the 'Hidden Normal' block to the 'Visible Normal Special Ability' block in the XML export, and changes their <type> from FAVOREDCLASSBONUS to FAVOREDCLASSBONUS.SPECIALQUALITY. Regenerated the three fixtures from the actual test output so the diff now compares clean. Verified with pfinttest and the full slowtest suite (all game modes + data tests) locally.
Contributor
Author
|
@LegacyKing you can accept the PR. |
LegacyKing
approved these changes
Jul 4, 2026
🚧 PCGen Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Pathfinder inttest failures on master (Cleric / Paladin / Rogue) introduced by #7658.
What broke
Commit 1439ee6 (PR #7658, issue #7478) is a legitimate data fix — it makes Favored Class Bonuses display on the character sheet, as the user requested. In
data/pathfinder/paizo/roleplaying_game/core_rulebook/cr_abilities_class.lstit:VISIBLE:DISPLAYfromBonus Hit PointandBonus Skill Rank(i.e.DISPLAY_ONLY→DEFAULT, so those abilities now appear in exports as well as in the GUI), and.SpecialQualityto theirTYPE.What the PR didn't touch is the character-sheet integration-test fixtures. So on master,
pcGenGUIPfrpgClericTest,pcGenGUIPfrpgPaladinTest, andpcGenGUIPfrpgRogueTestall fail with:The
<ability_object>blocks for the Favored Class Bonuses correctly moved from the "Hidden Normal" section to the "Visible Normal Special Ability" section in the produced XML, but the expected XMLs still had them at the bottom with the old type.Fix
Regenerated the three csheet fixtures from the actual test output so they reflect the new correct behaviour:
pf_Cleric.xml,pf_Paladin.xml,pf_Rogue.xml<ability_object>entries from the Hidden section to the Visible Normal Special Ability section,<type>fromFAVOREDCLASSBONUStoFAVOREDCLASSBONUS.SPECIALQUALITY,<hidden>T</hidden>to<hidden>F</hidden>.Nothing else changed in the XMLs.
Verified locally
./gradlew slowtest --tests …pcGenGUIPfrpgClericTest --tests …PaladinTest --tests …RogueTest --rerun-tasks→ all 3 pass./gradlew pfinttest --rerun-tasks(full Pathfinder inttest suite) → BUILD SUCCESSFUL./gradlew slowtest --rerun-tasks(all 5 game modes + data tests) → BUILD SUCCESSFUL in 7m 25s