Fix Dashboard auto-repair permission guidance - #348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dashboard's auto-repair button hid local write failures behind a generic unexpected-server-error message, leaving the warning and button unchanged. This change maps only recognized filesystem and owned upgrade-lock permission failures to a stable, path-free
operation.permission-deniedresponse; all 11 locales explain that the user should restartmemesh servefrom their own Terminal and retry. Restoring write access now lets the same button finish the repair while preserving unknown config keys and creating one backup.The investigation also found that
test:isolatedcould escape its throwaway HOME through an inherited npm cache, so nestednpm packfailed against a damaged owner cache. The shared isolated environment now owns its npm cache as well.Validation on
202cf69f5352b9131f67752e57ba918ea6ced0f7:npm run verify:releasenpm run test:isolated— 251 files, 3,805 passed, 9 skippednpm run test:packagednpm run test:packaged:upgrade— 4.5.1 and installed 4.9.4 upgrade pathsRelease remains separate: the repository's post-bump-change guard requires a new version bump after this and other fixes land, followed by exact-SHA host receipts and the soak gate.