chore(deps): bump cdb-converter to ^0.4.0 - #48
Open
mpicciolli wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the PCM database conversion layer by bumping cdb-converter to ^0.4.0, and refreshes the affected Vitest snapshots for pcm_get_table_schema where the converter now reports some STA_race columns with different SQLite type strings and updated offsets.
Changes:
- Bump
cdb-converterfrom^0.3.0to^0.4.0. - Sync
package-lock.jsonto the new dependency resolution. - Update
get-table-schemasnapshot expectations forSTA_raceacross fixtures (type/offset changes).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/tools/snapshots/get-table-schema.test.ts.snap | Refreshes STA_race schema snapshots to match new converter-reported column types/offsets. |
| package.json | Updates runtime dependency cdb-converter to ^0.4.0. |
| package-lock.json | Locks cdb-converter@0.4.0 (and transitive changes) to keep installs reproducible. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
8
to
12
| "name": "IDrace", | ||
| "notNull": false, | ||
| "primaryKey": false, | ||
| "type": "INTEGER 499717", | ||
| "type": "INTEGER 499712", | ||
| }, |
Update the lockfile and refresh the STA_race schema snapshots: the new converter reports the affected columns as INTEGER instead of NUMERIC and shifts a few column offsets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mpicciolli
force-pushed
the
chore/bump-cdb-converter-0.4.0
branch
from
August 17, 2026 18:34
e3b0d15 to
ee77a7d
Compare
Update the get-table-schema snapshot accordingly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdb-converterfrom^0.3.0to^0.4.0and syncpackage-lock.json.STA_raceschema snapshots: the new converter reports several columns asINTEGERinstead ofNUMERICand shifts a few column offsets.Test plan
npm test— 180 tests passing across 13 files.