Pdok 18835/vervanging trex v2 points and lines - #47
Open
DvBree wants to merge 24 commits into
Open
Conversation
kad-korpem
requested changes
Sep 2, 2026
| case geom.LineString: | ||
| return ix.lineTraceLine(g, tmsID, buffer) | ||
| case geom.Point: | ||
| return ix.lineTracePoint(g, tmsID, buffer) |
Collaborator
There was a problem hiding this comment.
Als lineTracePoint alleen een wrapper is om GetQBBoxWithBuffer - waarom dan niet die hele functie weglaten en direct GetQBBoxWithBuffer aanroepen?
| level := uint(tmID) + levelDiff | ||
| tmIDsByLevels[level] = tmID | ||
| return result | ||
| default: |
Collaborator
There was a problem hiding this comment.
Hier wordt nu alleen addPointsAndSnap gedaan voor polygons - is dat niet ook relevant voor punten en lijnen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
texelnow takes points and lines into account for encoding. This means thattexel snapnow actually populates the _encoded tables for point, multipoint, linestring, and multilinestring geometries.This change contains some refactoring.
processing.gofile has been heavily refactored. The new setup allows for general geometries, and the decoupling from geometric logic allows for better unit testing. The functionality should otherwise be unchanged.detect.gofile has been reorganised. On the one hand, again, this was necessary to allow general geometries. On the other hand, by reordering the functions and adding comments, the presentation has been improved.snap_test.go, which was incompatible with the new setup. This 800-line (!) test was fixed with some text replacements and new plumbing.Aside from unit tests, the code has been shown to provide visually satsifactory results when applied to a small portion of the BRT-A.
Type of change
Checklist: