Skip to content

petablint fails for PEtab v2 problems with only warnings #567

Closed

Description

@dweindl

For PEtab v2 problems, petablint exits with 1 if lint_problem returns any issues, including warnings (petab/petablint.py, if validation_issues: ... sys.exit(1)). For PEtab v1, only errors make it fail.

For example, unused conditions are allowed by the specification, and CheckUnusedConditions reports them as WARNING, but petablint still fails:

$ petablint problem.yaml; echo $?
WARNING: Conditions {'pred2', 'pred3', 'pred4', 'pred5'} are not used in the experiments table. [CheckUnusedConditions]
1

(Giordano_Nature2020 from the benchmark collection converted with petab1to2; same for Fujita_SciSignal2010.)

This makes petablint unusable for CI checks of valid v2 problems. Suggested fix: always log the issues, but exit with 1 only if validation_issues.has_errors(). If failing on warnings is wanted, it could be an opt-in flag.

🤖 Generated by an AI agent (Claude Code)

Activity

  1. added a commit that references this issue on Oct 21, 2026
    cacd2c1
  2. self-assigned this
    on Oct 25, 2026
  3. added a commit that references this issue on Oct 25, 2026
    71ff2ea
  4. added a commit that references this issue on Oct 26, 2026
    a285cad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions