Repository navigation
Don't fail petablint for PEtab v2 problems with only warnings - #569
Merged
Merged
Conversation
dweindl
force-pushed
the
petablint_v2_warnings
branch
from
October 21, 2026 18:52
eb14e6e to
cacd2c1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 79.06% 79.04% -0.02%
==========================================
Files 70 70
Lines 8155 8157 +2
Branches 1461 1461
==========================================
Hits 6448 6448
- Misses 1218 1220 +2
Partials 489 489 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
petablint_v2_warnings
branch
2 times, most recently
from
October 25, 2026 08:43
c4fbba6 to
6d42f16
Compare
dweindl
marked this pull request as ready for review
October 25, 2026 08:48
For PEtab v2 problems, `petablint` exited with 1 for any validation issue, including warnings. Now it reports all issues but only fails if there are errors, consistent with PEtab v1. Closes PEtab-dev#567. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Allows restoring the previous behavior of failing on warnings for PEtab v2 problems. Currently has no effect for PEtab v1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
petablint_v2_warnings
branch
from
October 25, 2026 13:12
6d42f16 to
fe2174a
Compare
dilpath
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For PEtab v2 problems,
petablintexited with 1 for any validation issue, including warnings such as unused conditions. Now it reports all issues but only fails if there are errors, consistent with PEtab v1.Use
petablint --fail-on-warningsto get the previous behavior. This option currently only affects PEtab v2 problems.Closes #567.
🤖 Generated with Claude Code