fix(achievements): case-insensitive wallet keys in achievement store (#276 #277 #278 #279) - #359
Merged
Darkvader-ship-it merged 2 commits intoSep 27, 2026
Conversation
PHASE-STELLAR#279) Canonicalize wallet keys to uppercase on every read/write so G... and g... addresses resolve to a single entry, and merge legacy mixed-case entries on read.
|
@daniella-techie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #276
Closes #277
Closes #278
Closes #279
Summary
lib/achievement-store.tsused the raw wallet string as the store key, soG...(uppercase) andg...(lowercase) versions of the same Stellar address produced separate entries. Unlocks, counters and streaks were split across them, and the same achievement could be unlocked twice.Changes
lib/achievement-store.tswalletKey(), which trims the address and uppercases it. Every read and write (ensureEntry,getAchievements,getWalletData,unlockAchievement,checkAndUnlock) now uses this canonical key.readStore()rewrites any existing mixed-case keys to the canonical key when it reads the file. If two entries collide, it merges them:unlocked_atmint_count,total_upvotes,follower_countandnarrator_countkeep the higher valuelast_dailytests/achievement-wallet-case.test.ts: new test. It checks that writes made with lowercase, uppercase and padded addresses all end up in one entry, and that existing split entries merge correctly.Test plan
npx tsx tests/achievement-wallet-case.test.tsnpx tsc --noEmit