WP 7.0: account for the raised minimum PHP version and removed polyfills#99
Merged
Conversation
WordPress 7.0 raised the minimum supported PHP version from 7.2.24 to 7.4 and, as a result, removed three polyfills from `src/wp-includes/compat.php` (`is_countable()`, `array_key_first()` and `array_key_last()`). They were introduced in PHP 7.3 and are now natively available given the new PHP 7.4 minimum. See https://core.trac.wordpress.org/ticket/62622 and https://core.trac.wordpress.org/changeset/61459. The `<exclude>` rules for these polyfills are kept so that projects targeting older WordPress versions (where the polyfills are still present) don't get false positives. Following the existing pattern, their comments in the ruleset are updated to note that they were removed in WP 7.0. The documented minimum PHP version and the `testVersion` example in the ruleset and the README are also updated to reflect the new PHP 7.4 requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress 7.0 raised the minimum supported PHP version from 7.2.24 to 7.4 and, as a result, removed three polyfills from
src/wp-includes/compat.php(is_countable(),array_key_first()andarray_key_last()). They were introduced in PHP 7.3 and are now natively available given the new PHP 7.4 minimum. See https://core.trac.wordpress.org/ticket/62622 and https://core.trac.wordpress.org/changeset/61459.The
<exclude>rules for these polyfills are kept so that projects targeting older WordPress versions (where the polyfills are still present) don't get false positives. Following the existing pattern, their comments in the ruleset are updated to note that they were removed in WP 7.0.The documented minimum PHP version and the
testVersionexample in the ruleset and theREADME.mdare also updated to reflect the new PHP 7.4 requirement.I also checked that WP 7.0 did not add any new polyfill that I could find.
Previous PR updating the list of polyfills: #88