Repository navigation
feat(planning): plan view inline meters (area used, workforce need vs housed) - #590
Merged
Merged
Conversation
… housed) - PMeter (src/ui/charts): small used-of-total bar, negative and full when over, role="img" with an aria-label - Status bar: 88 px area meter between "used / total" and "free / over" - Workforce: Need and Supply merged into one "Need / Housed" cell with a meter; "–" for empty tiers, a full negative meter for need without housing - Production building row lays out by the panel width (@container): delete button never on a line of its own - Material I/O: numbers no longer break mid-digit in the side column Spec: specs/2026-10-13-charts-02-plan-inline-meters.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prunplanner-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jplacht
added a commit
that referenced
this pull request
Oct 13, 2026
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (ace6f22) 4152 4061 97.81% Head commit (60974cd) 4152 (+0) 4061 (+0) 97.81% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#590) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The plan status bar showed area as "404 / 750 · 346 free", and Workforce showed Need, Supply and Open as three numbers per tier, so seeing how full a base is or which tier is short took reading and doing the maths. Small inline meters show it at a glance, without adding a chart to the planner. During review, two layout fixes on the same page were added: the production building row's delete button no longer wraps onto its own line, and Material I/O no longer breaks large numbers mid-digit.
Changes
PMeter(src/ui/charts/PMeter.vue): small used-of-total bar (6 px, ink at 72 %), negative and full when over,role="img"with an aria-label ("Area 54 % used")@containeron the panel): one line on a wide panel; on a narrow one name, qty and delete stay on top and the stats move below. The delete button lines up with the recipe rows' Tools columnPDataTable's table-wideword-break: break-wordbroke "-119,080.31" across two lines in the 450 px side column). Scoped to this table: the same rule kit-wide made Market Live's table overflowplan.components.workforce.table.need_housedadded (oldneed/supplyremoved),common.ui.meter.usedadded;docs/ui-and-i18n.mdmentions PMeterHow it was verified
pnpm test && pnpm test:components && pnpm tsc && pnpm lint && pnpm knip: PASS. (src/tests/main.test.ts, the app bootstrap smoke test, timed out at its 30 s limit twice under parallel load during development; it passes alone and in plain runs, and no startup code changed)plan,plan-new(andmarket-livefor the table change) at 1920, 1600, 1440, 1280, 1024, 768, 375: 0 regressions versus baseline;textOverlapandoverflowPxstay 0;smallTargetsTouchimproved (plan 768 −106, 375 −87; plan-new 768 −130, 375 −111)Screenshots
Desktop (1440)
Mobile (375)
🤖 Generated with Claude Code