Repository navigation
fix(account): registration form keeps the security planet after an error and shows every field error at its field - #591
Merged
Conversation
…ror and shows every field error at its field - Keep the security planet after a failed signup; "Use a different planet" draws another one and clears the answer - PostUserRegistration hands every field and message to the form (fieldErrors, replaces validationFields) - Field errors under their fields, cleared on edit, focus on the first; top alert for fix-the-fields, 429 throttling and unknown errors - Password rules in the hint, email format checked before submit - docs/analytics.md: signup events need earlier consent Spec: specs/2026-10-13-signup-02-form-errors.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prunplanner-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jplacht
added a commit
that referenced
this pull request
Oct 13, 2026
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 16 |
| Duplication | 0 |
🟢 Coverage ∅ diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (742ae59) 4152 4061 97.81% Head commit (9ef306c) 4152 (+0) 4061 (+0) 97.81% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#591) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
About 9 % of people who try to register never get an account. After any signup error the form drew a new security planet but kept the typed answer, so the next try failed on the planet; only the first message of the first field was shown, at the top of the form. Now a user who gets something wrong sees every problem under its field, keeps the planet they already looked up, and can succeed on the next try.
Changes
PostUserRegistrationhands every field and message to the form (fieldErrors, replacesvalidationFields)docs/analytics.md: signup events need earlier consentNotes:
How it was verified
pnpm test && pnpm tsc && pnpm lint && pnpm knippass;RegistrationComponent.test.ts25/25 in the component suite.smallTargetsTouch10 (header, inputs, Create Account, footer links, not the new button).Screenshots
Error states need typing and can't be captured by the screenshot runner; they were checked in the browser during QA.
Desktop (1440)
Mobile (375)
🤖 Generated with Claude Code