Fix output plot unit labels#1139
Open
GHX5T-SOL wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes output plot y-axis labels for the unit cases in #1135.
Related Issues
Closes #1135
Type of Change
Breaking Change?
If yes, describe the impact and migration path:
What was changed?
plot_aggregates(..., plot_type="pct_diff")outputs as percentage point changes.plot_aggregates(..., plot_type="levels")outputs as rates instead of model units.plot_gdp_ratiooutputs as percentage points of GDP.How was it tested?
.venv/bin/python -m pytest tests/test_output_plots.py -q.venv/bin/ruff format --check ogcore/output_plots.py tests/test_output_plots.py.venv/bin/ruff check ogcore/output_plots.py tests/test_output_plots.pygit diff --cached --checkLocal setup note:
uv sync --extra devcould not complete on this macOS x86_64 machine becausenumba==0.65.1tried to buildllvmlite==0.47.0without local LLVM development files. I ran the focused tests in a Python 3.11 editable environment using wheel-compatiblenumba==0.61.2; the changed code paths are limited to Matplotlib label selection and output plot tests.Screenshots / Output (if applicable)
N/A
Checklist
Reviewer Notes
The change is intentionally limited to axis labels and docs for existing plotted values; it does not alter plotted data.