Skip to content

fix: coderabbit comments

4bfad24
Select commit
Loading
Failed to load commit list.
Merged

Video Consultation Functionality #380

fix: coderabbit comments
4bfad24
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 20, 2026 in 1m 10s

Quality Gate failed

Failed conditions
B Security Rating on New Code (required β‰₯ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 212 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuA&open=AZ09vpnFwjujtYZDhAuA&pullRequest=380

Check warning on line 231 in src/test/java/com/iemr/common/service/videocall/VideoCallServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1xmsfxa94uUuRcC1YO&open=AZ1xmsfxa94uUuRcC1YO&pullRequest=380

Check warning on line 88 in src/main/java/com/iemr/common/utils/km/openkm/OpenKMServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

String contains no format specifiers.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4W5Ao3DRkjycYXE&open=AZ1uE4W5Ao3DRkjycYXE&pullRequest=380

Check warning on line 394 in src/main/java/com/iemr/common/service/sms/SMSServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uBNj26AnbEIDJUSdr&open=AZ1uBNj26AnbEIDJUSdr&pullRequest=380

Check warning on line 192 in src/main/java/com/iemr/common/service/kmfilemanager/KMFileManagerServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1HYmNtZjBb0RPXCXcM&open=AZ1HYmNtZjBb0RPXCXcM&pullRequest=380

Check warning on line 101 in src/main/java/com/iemr/common/controller/videocall/VideoCallController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not log user-controlled data.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ2pXojqFuv4wYSBhWb-&open=AZ2pXojqFuv4wYSBhWb-&pullRequest=380

Check warning on line 366 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuF&open=AZ09vpnFwjujtYZDhAuF&pullRequest=380

Check warning on line 244 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuB&open=AZ09vpnFwjujtYZDhAuB&pullRequest=380

Check warning on line 234 in src/main/java/com/iemr/common/service/nhm_dashboard/NHM_DashboardServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ0-RtfoAgn4AWNDCoG4&open=AZ0-RtfoAgn4AWNDCoG4&pullRequest=380

Check warning on line 301 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuD&open=AZ09vpnFwjujtYZDhAuD&pullRequest=380

Check failure on line 226 in src/main/java/com/iemr/common/utils/JwtUserIdValidationFilter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "/video-consultation/resolve" 3 times.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ127zB08xinLLaxfd5Q&open=AZ127zB08xinLLaxfd5Q&pullRequest=380

Check warning on line 246 in src/main/java/com/iemr/common/service/services/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4PnAo3DRkjycYW9&open=AZ1uE4PnAo3DRkjycYW9&pullRequest=380

Check warning on line 397 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuG&open=AZ09vpnFwjujtYZDhAuG&pullRequest=380

Check warning on line 51 in src/main/java/com/iemr/common/utils/km/openkm/OpenKMServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this duplicated import.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4W5Ao3DRkjycYXF&open=AZ1uE4W5Ao3DRkjycYXF&pullRequest=380

Check warning on line 248 in src/main/java/com/iemr/common/service/services/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4PnAo3DRkjycYW7&open=AZ1uE4PnAo3DRkjycYW7&pullRequest=380

Check warning on line 204 in src/test/java/com/iemr/common/service/videocall/VideoCallServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1xmsfxa94uUuRcC1YL&open=AZ1xmsfxa94uUuRcC1YL&pullRequest=380

Check warning on line 185 in src/test/java/com/iemr/common/service/videocall/VideoCallServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1xmsfxa94uUuRcC1YK&open=AZ1xmsfxa94uUuRcC1YK&pullRequest=380

Check warning on line 155 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAt-&open=AZ09vpnFwjujtYZDhAt-&pullRequest=380

Check warning on line 247 in src/main/java/com/iemr/common/service/beneficiary/RegisterBenificiaryServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4OvAo3DRkjycYW5&open=AZ1uE4OvAo3DRkjycYW5&pullRequest=380

Check warning on line 128 in src/main/java/com/iemr/common/utils/http/HTTPRequestInterceptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge the previous cases into this one using comma-separated label.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ12r7AJPNC-nQ5ClRu8&open=AZ12r7AJPNC-nQ5ClRu8&pullRequest=380

Check warning on line 248 in src/main/java/com/iemr/common/service/services/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4PnAo3DRkjycYW_&open=AZ1uE4PnAo3DRkjycYW_&pullRequest=380

Check warning on line 438 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuH&open=AZ09vpnFwjujtYZDhAuH&pullRequest=380

Check failure on line 435 in src/main/java/com/iemr/common/service/sms/SMSServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "phoneno" 3 times.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1wqBOm1MRvjmKty9tm&open=AZ1wqBOm1MRvjmKty9tm&pullRequest=380

Check warning on line 502 in src/main/java/com/iemr/common/service/cti/CTIServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ09vpnFwjujtYZDhAuJ&open=AZ09vpnFwjujtYZDhAuJ&pullRequest=380

Check warning on line 237 in src/main/java/com/iemr/common/service/beneficiary/RegisterBenificiaryServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ1uE4OvAo3DRkjycYW0&open=AZ1uE4OvAo3DRkjycYW0&pullRequest=380