fix(BeneficiaryRegistrationController): added checks for null to prev…

[FrankOHara43]

Description

JIRA ID: N/A

Added defensive null checks in setBeneficiaryGender() to prevent potential NullPointerExceptions when processing beneficiary data.

Changes:

• Added an early return when the beneficiary list is null or empty.
• Added a null check for individual BeneficiaryModel elements before processing.
• Retained the existing null validation for m_gender and genderName.

Summary by CodeRabbit

• Bug Fixes
  • Improved robustness of beneficiary data processing by adding defensive null checks when assigning gender information, preventing potential errors from incomplete or missing data.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f28aba5-db88-44fb-80cb-b9a15e057d00

📥 Commits

Reviewing files that changed from the base of the PR and between 9f23f79 and 67edbdd.

📒 Files selected for processing (1)

• src/main/java/com/iemr/common/controller/beneficiary/BeneficiaryRegistrationController.java

---

📝 Walkthrough

Walkthrough

The setBeneficiaryGender method in BeneficiaryRegistrationController now defensively validates input before processing. It checks for null or empty input lists and null list elements, and ensures genderName is only set when both the gender object and its name are non-null.

Changes

Cohort / File(s)	Summary
Null Safety Enhancement src/main/java/com/iemr/common/controller/beneficiary/BeneficiaryRegistrationController.java	Added defensive null and empty checks to setBeneficiaryGender method to safely handle null input lists and null gender objects before accessing getGenderName().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Null checks bloom like clover,
No crashes shall come to pass,
Defensive code stands guard,
Safe gender flows at last!
Rabbit's burrow is safer still!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding null checks to the setBeneficiaryGender() method in BeneficiaryRegistrationController to guard against null/empty lists and null elements.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud