replaced e.printStackTrace() with SLF4J logger in PatientExtProvider#205
replaced e.printStackTrace() with SLF4J logger in PatientExtProvider#205areychana wants to merge 1 commit intoPSMRI:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA static SLF4J logger was added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



📋 Description
JIRA ID:
PatientExtProvider.javahas no SLF4J logger declared, so both catch blocks fall back toe.printStackTrace(). Every other class in this codebase usesLoggerFactory.getLogger(...)so this one was just missed. In production, stdout is not picked up by log aggregators so any exception thrown from these FHIR endpoints disappears silently with no trace in logs.✅ Type of Change
ℹ️ Additional Information
Added SLF4J imports, declared a logger field on the class, and replaced both
e.printStackTrace()calls withlogger.error(message, e). Logging only change, no behaviour modified. Follows the same pattern used everywhere else in the project.Summary by CodeRabbit