feat: add checkout domains from api-specifications#2432 - #233
Draft
cursor[bot] wants to merge 3 commits into
Draft
feat: add checkout domains from api-specifications#2432#233cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: Jed Patterson <jed.patterson@paddle.com>
Co-authored-by: Jed Patterson <jed.patterson@paddle.com>
Co-authored-by: Jed Patterson <jed.patterson@paddle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the public Checkout Domains resource and folds in the pending DX-906 baseline so the path-validation relaxation from api-specifications#2432 is usable in the Node SDK.
get(),delete(), andverifyPaymentMethod()accept plainstringIDs and pass them directly intoPathParameters, including legacy UUIDs. The additive baseline makes this a minor SDK change, so the package version is bumped to3.9.0.Linear issue: DX-1060
Spec-to-SDK mapping
domain_idfor get, delete, and verify-payment-methodsrc/resources/checkout-domains/index.ts,src/__tests__/resources/checkout-domains.test.tssrc/resources/checkout-domains/**,src/paddle.ts,src/resources/index.tssrc/types/checkout-domains/**,src/entities/checkout-domains/**,src/enums/checkout-domains/**, their root barrels, andsrc/__tests__/mocks/resources/checkout-domains.mock.tsCHANGELOG.md,package.jsonIntentionally excluded
PATCH /checkout-domains/{domain_id}remains@internalUseOnly.POST /checkout-domains/{domain_id}/resubmitandPOST /checkout-domainsremain@partnerOnly.string; no path regex, branded type, or runtime validation was introduced.Validation
pnpm install --frozen-lockfile— passedpnpm build— passedpnpm typecheck:tests— passedpnpm test --runInBand— 35 suites and 279 tests passedpnpm lint --ignore-pattern src/version.ts— passed (the generated, git-ignoredsrc/version.tshas the documented pre-existingeol-lastissue)pnpm prettier— passedThis PR was created by an automated spec-sync agent.