Skip to content

DF/data4es: Stage 040 (progress data) (refined history). - #381

Merged
mgolosova merged 9 commits into
masterfrom
data4es-progress-data-refined-history
Aug 5, 2020
Merged

DF/data4es: Stage 040 (progress data) (refined history).#381
mgolosova merged 9 commits into
masterfrom
data4es-progress-data-refined-history

Conversation

@mgolosova

@mgolosova mgolosova commented Jul 29, 2020

Copy link
Copy Markdown
Collaborator

Waits for: (#368,#365)->#369 -> #380, #366

Add new stage (040) "progress".
This stage generates documents of new type -- task_progress -- to be indexed in a separate index and used to produce aggrerated statistics on task/campaign progress.

This is the last PR in a row of PRs that replace #359.


Overrides #374.

If the input message for some reason does not contain required fields
like 'taskid' or 'task_timestamp' -- we cannot process it properly, but
it should not interrupt the whole ETL process.
@mgolosova mgolosova self-assigned this Jul 29, 2020
@mgolosova
mgolosova marked this pull request as draft July 29, 2020 11:08
Base automatically changed from data4es-017-steps-refined-history to master July 29, 2020 11:09
@mgolosova
mgolosova marked this pull request as ready for review July 29, 2020 11:10
@mgolosova
mgolosova requested a review from Evildoor July 29, 2020 11:10

@Evildoor Evildoor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data samples seem to be wrong.

In 040's output, the index is production_progress, while in the code it is progress.
In 019's output, index of all records is tasks_production, while new ones are supposed to go into their own index - most likely due to the previous problem, since 019's ES_INDEX contains 'progress' => getenv('ES_INDEX_PROGRESS'), where the latter is set to production_progress by sourcing ES config.

Comment thread Utils/Dataflow/040_progress/README Outdated
@mgolosova

Copy link
Copy Markdown
Collaborator Author

@Evildoor, fixed now.

@Evildoor Evildoor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, did not notice it before: 019's input now correctly points to 040, but 019's README still says that its samples are made from 017's ones. And 040's README has no section for samples at all.

Remove links to origins of the input data samples:
* link to Stage 017 is obsolete;
* actual information can be obtained from the symlinks in the `input/`
  directory;
* when `data4es` shape is changed it should affect only the new/removed
  stages and the shape itself, not stages before and/or after the
  new/removed ones.
Add 'Samples' sectoion.
@mgolosova

Copy link
Copy Markdown
Collaborator Author

@Evildoor,

019's input now correctly points to 040, but 019's README still says that its samples are made from 017's ones. And 040's README has no section for samples at all.

Fixed now.

@mgolosova
mgolosova merged commit e37d4f2 into master Aug 5, 2020
@mgolosova
mgolosova deleted the data4es-progress-data-refined-history branch August 5, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants