ci.yml: fix flakiness - #39
Merged
Merged
Conversation
veprbl
force-pushed
the
pr/ci_timeout
branch
from
September 2, 2026 08:37
e9c7dea to
cfe3d78
Compare
jobs are flaky on CI
Fix the inverted timeout>interval (now 5s timeout, 10s interval).
…pendents The panda-database image runs first-run init on a fresh CI volume (initdb + panda_db_init.sh) and restarts the container once. During that window it listens on the Unix socket only and transitions through unhealthy. Starting dependents via depends_on: service_healthy at the same time races this and intermittently aborts with 'container ...-postgres-1 is unhealthy'. Start postgres/activemq/mariadb first, wait for two consecutive healthy reads (past the init restart), then bring up the rest.
veprbl
force-pushed
the
pr/ci_timeout
branch
from
September 2, 2026 13:54
8d661ed to
9f70642
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated Postgres healthcheck still references an env var not set inside the container, and the action’s Postgres container detection relies on a constructed name that can break under project-name normalization.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR targets CI flakiness in the PanDA Compose GitHub Actions smoke test by making startup sequencing and timeouts more tolerant of first-run database initialization behavior.
Changes:
- Adjust PostgreSQL healthcheck parameters in
docker-compose.ymlto check readiness more frequently with a shorter timeout. - Update the composite action to start base services first and explicitly wait for PostgreSQL to reach a stable healthy state before starting dependents.
- Increase the CI integration-test polling timeout from 10 to 20 minutes to reduce spurious failures.
File summaries
| File | Description |
|---|---|
| docker-compose.yml | Tweaks Postgres healthcheck command/interval/timeout used by Compose health gating. |
| action.yml | Adds staged startup + Postgres “stable healthy” wait logic to avoid depends_on health race during init/restart. |
| .github/workflows/ci.yml | Extends job status polling deadline/messages to 20 minutes. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobs are flaky on CI
example: https://github.com/PanDAWMS/panda-compose/actions/runs/33398026763/job/99977789883