Repository navigation
fix: security hardening and input validation across auth, oracle, and stellar services - #634
Merged
nonsobethel0-dev merged 4 commits intoSep 25, 2026
Conversation
…eware log messages Wallet addresses are now logged as first 8 + last 4 characters (e.g., GBARCZTW...XLDL) to prevent user tracking and deanonymization via production log streams.
…ainfall controller Add defense-in-depth validation that month is an integer between 1 and 12 in the POST /oracle/fetch/rainfall endpoint, matching the validation already present in the query-param getRainfall endpoint.
…acing timeout error The withTimeout method previously included the internal RPC operation name (e.g., 'sendTransaction', 'getAccount') in the HttpException response, which could expose implementation details to clients. The error message is now generic.
…ding before database write Add validation that confidence is a finite number between 0 and 100 before persisting an oracle reading. Invalid confidence values are rejected with an error log to prevent corrupted downstream aggregation. Also fix pre-existing syntax error: uncommented Parashield-Protocol#548 issue reference in onFailure method.
|
@KidDev88 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #542, Closes #533, Closes #532, Closes #531
Type of Change
Summary
Addresses 4 security and validation issues across the backend:
Motivation / Context
Closes #542, Closes #533, Closes #532, Closes #531
Testing
GCO4G742...SATTformat in logs)Changes
src/auth/auth.middleware.tstruncateAddress()helper; all 11 log messages now use truncated addressessrc/oracle/oracle.controller.tsfetchRainfallsrc/stellar/stellar.service.tsoperationfield from HttpException inwithTimeoutsrc/oracle/oracle.service.tspersistReading; fixed pre-existing uncommented#548reference